56888[TASK] Deprecate methods and constants in ValidatorResolver
Commit message
Review
-
Code review CR +2
- Frank Nägler +2
- Anja Leichsenring +1
-
Verified V +2
- Frank Nägler +2
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 1
Files 5
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-85005-DeprecateMethodsAndConstantsInValidatorResolver.rstnew+44 −0
- typo3/sysext/extbase/Classes/Validation/ValidatorResolver.php4+25 −0
- typo3/sysext/extbase/Tests/Unit/Validation/ValidatorResolverTest.php+0 −154
- typo3/sysext/extbase/Tests/UnitDeprecated/Validation/ValidatorResolverTest.php+163 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+28 −0
Review log 1825
-
Alexander Schnitzler uploaded patch set 1 05/08/18, 13:07
-
TYPO3com voted on patch set 1 V -1 05/08/18, 13:17 Completed build in 09m 16s on Tue, 8 May, 03:17 PM Test Summary: 61 of 31239 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23153
-
Alexander Schnitzler uploaded patch set 2 05/08/18, 13:19
-
TYPO3com voted on patch set 2 V -1 05/08/18, 13:26 Completed build in 06m 57s on Tue, 8 May, 03:26 PM Test Summary: 18 of 31210 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23154
-
Alexander Schnitzler uploaded patch set 3 05/14/18, 16:18
-
Alexander Schnitzler updated the commit message in patch set 4 05/14/18, 16:25
-
TYPO3com voted on patch set 3 V +1 05/14/18, 16:26 Completed build in 08m 06s on Mon, 14 May, 06:26 PM Test Summary: 31156 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23489
-
TYPO3com voted on patch set 4 V +1 05/14/18, 16:32 Completed build in 07m 51s on Mon, 14 May, 06:32 PM Test Summary: 31156 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23491
-
Alexander Schnitzler wrote 05/15/18, 10:47
Topic set to Extbase -
Alexander Schnitzler uploaded patch set 5 05/15/18, 10:58
-
Georg Ringer voted on patch set 5 V +1 CR +1 05/15/18, 11:04
-
TYPO3com voted on patch set 5 V +1 05/15/18, 11:06 Completed build in 07m 45s on Tue, 15 May, 01:06 PM Test Summary: 31159 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23504
-
Alexander Schnitzler uploaded patch set 6 05/17/18, 06:02
-
Alexander Schnitzler commented on patch set 6 05/17/18, 06:03
Last patchset is actually just a rebase. There was no merge conflict however... -
TYPO3com voted on patch set 6 V +1 05/17/18, 06:10 Completed build in 07m 48s on Thu, 17 May, 08:10 AM Test Summary: 31159 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23584
-
Alexander Schnitzler uploaded patch set 7 05/17/18, 09:01
-
TYPO3com voted on patch set 7 V +1 05/17/18, 09:08 Completed build in 06m 56s on Thu, 17 May, 11:08 AM Test Summary: 31203 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23604
-
Anja Leichsenring voted on patch set 7 V +1 CR +1 05/17/18, 09:13
-
Frank Nägler voted on patch set 7 CR +1 05/17/18, 14:04
-
Frank Nägler commented on patch set 7 CR -1 05/17/18, 14:13
The core use methods which calls the deprecated methods, so a lot of deprecation messages are generated. The rule is: the core should never produce deprecation logs. If a method is deprecated, we have to ensure that this methods are not called from core side anymore. -
Alexander Schnitzler commented on patch set 7 05/17/18, 15:12
The core doesn't call these methods any more except through methods that are deprecated by themselves. Especially during the ClassSchema generation. If you found a place where the core still calls one of these methods, please be so kind to tell me where. I didn't find any myself when creating this patch. -
Alexander Schnitzler commented on patch set 7 05/17/18, 15:21
ValidatorResolver.php:237This method is only called by buildMethodArgumentsValidatorConjunctions, which is deprecated itself.ValidatorResolver.php:379This method is called when using @validate which triggers a deprecation call itself. It's also called by getMethodValidateAnnotations which is deprecated. getMethodValidateAnnotations is only called by buildMethodArgumentsValidatorConjunctions which is deprecated.ValidatorResolver.php:413This is only called by parseValidatorAnnotation, which is deprecated with this patch.ValidatorResolver.php:439This is only called by parseValidatorOptions. -
Frank Nägler commented on patch set 7 CR +1 05/18/18, 14:01
I am sorry, I don't know what I have seen... I checked it again and you are right. -
Frank Nägler voted on patch set 7 V +2 CR +2 05/18/18, 14:04
-
Frank Nägler merged patch set 8 05/18/18, 14:04