Review main Merged

56888[TASK] Deprecate methods and constants in ValidatorResolver

Alexander Schnitzler CR +2 V +2 Hard +260 −154 updated 05/18/18, 14:04

Commit message

Several methods and constants in the ValidatorResolver class
are now marked as deprecated because they are no longer needed
to resolve validators.

As these methods and constants are to be considered internal api
it is very unlikely that anyone is affected by this change.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Anja Leichsenring +1
  • Verified V +2
    • Frank Nägler +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 1825

  1. Alexander Schnitzler uploaded patch set 1 05/08/18, 13:07

  2. TYPO3com voted on patch set 1 V -1 05/08/18, 13:17 Completed build in 09m 16s on Tue, 8 May, 03:17 PM Test Summary: 61 of 31239 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23153

  3. Alexander Schnitzler uploaded patch set 2 05/08/18, 13:19

  4. TYPO3com voted on patch set 2 V -1 05/08/18, 13:26 Completed build in 06m 57s on Tue, 8 May, 03:26 PM Test Summary: 18 of 31210 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23154

  5. Alexander Schnitzler uploaded patch set 3 05/14/18, 16:18

  6. Alexander Schnitzler updated the commit message in patch set 4 05/14/18, 16:25

  7. TYPO3com voted on patch set 3 V +1 05/14/18, 16:26 Completed build in 08m 06s on Mon, 14 May, 06:26 PM Test Summary: 31156 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23489

  8. TYPO3com voted on patch set 4 V +1 05/14/18, 16:32 Completed build in 07m 51s on Mon, 14 May, 06:32 PM Test Summary: 31156 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23491

  9. Alexander Schnitzler wrote 05/15/18, 10:47

    Topic set to Extbase
  10. Alexander Schnitzler uploaded patch set 5 05/15/18, 10:58

  11. Georg Ringer voted on patch set 5 V +1 CR +1 05/15/18, 11:04

  12. TYPO3com voted on patch set 5 V +1 05/15/18, 11:06 Completed build in 07m 45s on Tue, 15 May, 01:06 PM Test Summary: 31159 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23504

  13. Alexander Schnitzler uploaded patch set 6 05/17/18, 06:02

  14. Alexander Schnitzler commented on patch set 6 05/17/18, 06:03

    Last patchset is actually just a rebase. There was no merge conflict however...
  15. TYPO3com voted on patch set 6 V +1 05/17/18, 06:10 Completed build in 07m 48s on Thu, 17 May, 08:10 AM Test Summary: 31159 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23584

  16. Alexander Schnitzler uploaded patch set 7 05/17/18, 09:01

  17. TYPO3com voted on patch set 7 V +1 05/17/18, 09:08 Completed build in 06m 56s on Thu, 17 May, 11:08 AM Test Summary: 31203 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23604

  18. Anja Leichsenring voted on patch set 7 V +1 CR +1 05/17/18, 09:13

  19. Frank Nägler voted on patch set 7 CR +1 05/17/18, 14:04

  20. Frank Nägler commented on patch set 7 CR -1 05/17/18, 14:13

    The core use methods which calls the deprecated methods, so a lot of deprecation messages are generated. The rule is: the core should never produce deprecation logs. If a method is deprecated, we have to ensure that this methods are not called from core side anymore.
  21. Alexander Schnitzler commented on patch set 7 05/17/18, 15:12

    The core doesn't call these methods any more except through methods that are deprecated by themselves. Especially during the ClassSchema generation. If you found a place where the core still calls one of these methods, please be so kind to tell me where. I didn't find any myself when creating this patch.
  22. Alexander Schnitzler commented on patch set 7 05/17/18, 15:21

    ValidatorResolver.php:237

    This method is only called by buildMethodArgumentsValidatorConjunctions, which is deprecated itself.

    ValidatorResolver.php:379

    This method is called when using @validate which triggers a deprecation call itself. It's also called by getMethodValidateAnnotations which is deprecated. getMethodValidateAnnotations is only called by buildMethodArgumentsValidatorConjunctions which is deprecated.

    ValidatorResolver.php:413

    This is only called by parseValidatorAnnotation, which is deprecated with this patch.

    ValidatorResolver.php:439

    This is only called by parseValidatorOptions.
  23. Frank Nägler commented on patch set 7 CR +1 05/18/18, 14:01

    I am sorry, I don't know what I have seen... I checked it again and you are right.
  24. Frank Nägler voted on patch set 7 V +2 CR +2 05/18/18, 14:04

  25. Frank Nägler merged patch set 8 05/18/18, 14:04