Review main Merged

56896[TASK] Deprecate methods in ReflectionService

Alexander Schnitzler CR +2 V +2 Hard +523 −109 updated 06/12/18, 08:57

Commit message

As the ReflectionService class is only a wrapper to call
methods on ClassSchema instances, all wrapper methods
should be deprecated and removed to make space for
a new, superior api.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Stefan Neufeind +1
  • Verified V +2
    • Frank Nägler +2
    • Stefan Neufeind +1
    • TYPO3com +1 CI

Issues 1

Files 16

Review log 3245

Show 1220 earlier messages
  1. Alexander Schnitzler uploaded patch set 1 05/09/18, 08:16

  2. TYPO3com voted on patch set 1 V -1 05/09/18, 08:30 Completed build in 14m 25s on Wed, 9 May, 10:30 AM Test Summary: 3 of 31293 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23224

  3. TYPO3com commented on patch set 1 05/09/18, 08:32 Completed build in 30m 30s on Wed, 9 May, 10:32 AM Test Summary: 2 of 31293 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23224

  4. Alexander Schnitzler uploaded patch set 2 05/14/18, 16:21

  5. TYPO3com voted on patch set 2 V -1 05/14/18, 16:29 Completed build in 08m 08s on Mon, 14 May, 06:29 PM Test Summary: 2 of 31409 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23490

  6. Alexander Schnitzler uploaded patch set 3 05/15/18, 09:30

  7. TYPO3com voted on patch set 3 V -1 05/15/18, 09:30 Completed build in 06s on Tue, 15 May, 11:30 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23500

  8. Alexander Schnitzler uploaded patch set 4 05/15/18, 09:38

  9. TYPO3com voted on patch set 4 V +1 05/15/18, 09:47 Completed build in 08m 31s on Tue, 15 May, 11:47 AM Test Summary: 31165 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23501

  10. Alexander Schnitzler uploaded patch set 5 05/15/18, 10:45

  11. TYPO3com voted on patch set 5 V +1 05/15/18, 10:53 Completed build in 07m 36s on Tue, 15 May, 12:53 PM Test Summary: 31165 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23503

  12. Georg Ringer voted on patch set 5 CR +1 05/15/18, 12:24

  13. Alexander Schnitzler wrote 05/15/18, 12:44

    Topic set to Extbase
  14. Alexander Schnitzler uploaded patch set 6 05/17/18, 06:04

  15. Alexander Schnitzler commented on patch set 6 05/17/18, 06:04

    Last patchset is actually just a rebase. There was no merge conflict however...
  16. TYPO3com voted on patch set 6 V +1 05/17/18, 06:12 Completed build in 07m 34s on Thu, 17 May, 08:12 AM Test Summary: 31165 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23585

  17. Alexander Schnitzler uploaded patch set 7 05/17/18, 09:05

  18. TYPO3com voted on patch set 7 V +1 05/17/18, 09:13 Completed build in 08m 30s on Thu, 17 May, 11:13 AM Test Summary: 31209 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23605

  19. Alexander Schnitzler commented on patch set 7 CR -1 05/17/18, 09:14

    Please first merge https://review.typo3.org/#/c/56970/. Afterwards this patch needs a rebase anyway.
  20. Alexander Schnitzler voted on patch set 7 CR 0 05/28/18, 08:28

  1. Alexander Schnitzler uploaded patch set 8 05/28/18, 08:53

  2. TYPO3com voted on patch set 8 V -1 05/28/18, 08:59 Completed build in 06m 33s on Mon, 28 May, 10:59 AM Test Summary: 3 of 31335 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23802

  3. Alexander Schnitzler uploaded patch set 9 05/28/18, 09:01

  4. TYPO3com voted on patch set 9 V +1 05/28/18, 09:09 Completed build in 07m 07s on Mon, 28 May, 11:09 AM Test Summary: 31088 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23803

  5. Wouter Wolters voted on patch set 9 CR +1 05/28/18, 11:28

  6. Tymoteusz Motylewski commented on patch set 9 05/30/18, 17:02

    one of the behavior change is that the UnknownClassException are not captured any more. Is that intended?
  7. Anja Leichsenring uploaded patch set 10 06/01/18, 11:36

  8. TYPO3com voted on patch set 10 V +1 06/01/18, 11:44 Completed build in 07m 33s on Fri, 1 Jun, 01:44 PM Test Summary: 31125 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23977

  9. Anja Leichsenring commented on patch set 10 06/01/18, 11:48

    > Patch Set 9: > > one of the behavior change is that the UnknownClassException are not captured any more. Is that intended? Can you explain where you see this behavior change? The Exception is not caught, but it never was, as far as I can see.
  10. Alexander Schnitzler uploaded patch set 11 06/02/18, 19:23

  11. TYPO3com voted on patch set 11 V +1 06/02/18, 19:31 Completed build in 07m 00s on Sat, 2 Jun, 09:31 PM Test Summary: 31095 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24005

  12. Alexander Schnitzler commented on patch set 11 V -1 06/02/18, 19:45

    Would be great to have the new api in place. The api should be on the ClassSchema objects to be able to get rid of the ReflectionService method.
  13. Alexander Schnitzler commented on patch set 11 06/02/18, 19:47

    Regarding the uncaught exceptions: The change is intended because we operate on classes and expect them to actually exist. A class schema for a non-existant class does not make sense, thus UnknownClassException's should be thrown.
  14. Benni Mack commented on patch set 11 06/09/18, 15:19

    Alex, why did you give a -1 then?
  15. Anja Leichsenring voted on patch set 11 V +1 CR +1 06/09/18, 15:58

  16. Alexander Schnitzler voted on patch set 11 V 0 06/10/18, 10:10

  17. Andreas Kienast voted on patch set 11 CR +1 06/10/18, 12:00

  18. Stefan Neufeind commented on patch set 11 06/11/18, 17:56

    ObjectConverter.php:126

    use $classSchema here instead
  19. Stefan Neufeind commented on patch set 11 CR +1 06/11/18, 17:57

    looks fine, just a small nitpick (see inline)
  20. Frank Nägler uploaded patch set 12 06/12/18, 07:52

  21. Frank Nägler voted on patch set 12 V +1 CR +1 06/12/18, 07:52

  22. Stefan Neufeind voted on patch set 12 V +1 CR +1 06/12/18, 07:56

  23. TYPO3com voted on patch set 12 V +1 06/12/18, 08:00 Completed build in 07m 49s on Tue, 12 Jun, 10:00 AM Test Summary: 32673 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24344

  24. Frank Nägler voted on patch set 12 V +2 CR +2 06/12/18, 08:57

  25. Frank Nägler merged patch set 13 06/12/18, 08:57