Review main Merged

56902[TASK] Use variable argument-list ObjectManager and Container

Alexander Schnitzler CR +2 V +2 Easy +12 −13 updated 05/10/18, 10:14

Commit message

Supported since PHP 5.6. This makes the code easier to read
and allows to properly document using phpdoc.

https://secure.php.net/manual/en/functions.arguments.php#functions.variable-arg-list

Review

  • Code review CR +2
    • Susi Moog +2
    • Mathias Schreiber +1
    • Mathias Brodala +1
  • Verified V +2
    • Susi Moog +2
    • Mathias Schreiber +1
    • Mathias Brodala +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1317

  1. Alexander Schnitzler uploaded patch set 1 05/09/18, 15:16

  2. Mathias Brodala commented on patch set 1 05/09/18, 15:20

    ObjectManager.php:94

    This can be done within Container::instanciateObject() too I guess. (Only the makeInstance() call.)
  3. Alexander Schnitzler commented on patch set 1 05/09/18, 15:21

    Good point!
  4. TYPO3com voted on patch set 1 V +1 05/09/18, 15:24 Completed build in 08m 18s on Wed, 9 May, 05:24 PM Test Summary: 31003 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23242

  5. Alexander Schnitzler uploaded patch set 2 05/09/18, 15:33

  6. Mathias Brodala commented on patch set 2 CR -1 05/09/18, 15:35

    Container.php:96

    This is a breaking change. Before a single array argument was expected, now all arguments must be passed separately.
  7. Mathias Brodala commented on patch set 2 05/09/18, 15:36

    As said, please only change this for the makeInstance() call within the Container. ;-)
  8. Alexander Schnitzler commented on patch set 2 05/09/18, 15:39

    Container.php:96 Reply

    Don't think so because this class is very much internal stuff and no public api. However, I will adjust this and properly mark the method(s) internal.
  9. TYPO3com voted on patch set 2 V -1 05/09/18, 15:42 Completed build in 08m 07s on Wed, 9 May, 05:42 PM Test Summary: 51 of 31250 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23244

  10. Alexander Schnitzler uploaded patch set 3 05/09/18, 15:43

  11. Alexander Schnitzler uploaded patch set 4 05/09/18, 15:47

  12. TYPO3com voted on patch set 3 V -1 05/09/18, 15:50 Completed build in 07m 02s on Wed, 9 May, 05:50 PM Test Summary: 493 of 30608 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23245

  13. TYPO3com voted on patch set 4 V +1 05/09/18, 15:54 Completed build in 06m 02s on Wed, 9 May, 05:54 PM Test Summary: 31003 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23247

  14. Mathias Brodala commented on patch set 4 V +1 CR +1 05/09/18, 15:56

    Verified by Bamboo.
  15. Mathias Schreiber voted on patch set 4 V +1 CR +1 05/10/18, 09:57

  16. Susi Moog voted on patch set 4 V +2 CR +2 05/10/18, 10:14

  17. Susi Moog merged patch set 5 05/10/18, 10:14