56902[TASK] Use variable argument-list ObjectManager and Container
Commit message
Review
-
Code review CR +2
- Susi Moog +2
- Mathias Schreiber +1
- Mathias Brodala +1
-
Verified V +2
- Susi Moog +2
- Mathias Schreiber +1
- Mathias Brodala +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1317
-
Alexander Schnitzler uploaded patch set 1 05/09/18, 15:16
-
Mathias Brodala commented on patch set 1 05/09/18, 15:20
-
Alexander Schnitzler commented on patch set 1 05/09/18, 15:21
Good point! -
TYPO3com voted on patch set 1 V +1 05/09/18, 15:24 Completed build in 08m 18s on Wed, 9 May, 05:24 PM Test Summary: 31003 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23242
-
Alexander Schnitzler uploaded patch set 2 05/09/18, 15:33
-
Mathias Brodala commented on patch set 2 CR -1 05/09/18, 15:35
Container.php:96This is a breaking change. Before a single array argument was expected, now all arguments must be passed separately. -
Mathias Brodala commented on patch set 2 05/09/18, 15:36
As said, please only change this for the makeInstance() call within the Container. ;-) -
Alexander Schnitzler commented on patch set 2 05/09/18, 15:39
Container.php:96ReplyDon't think so because this class is very much internal stuff and no public api. However, I will adjust this and properly mark the method(s) internal. -
TYPO3com voted on patch set 2 V -1 05/09/18, 15:42 Completed build in 08m 07s on Wed, 9 May, 05:42 PM Test Summary: 51 of 31250 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23244
-
Alexander Schnitzler uploaded patch set 3 05/09/18, 15:43
-
Alexander Schnitzler uploaded patch set 4 05/09/18, 15:47
-
TYPO3com voted on patch set 3 V -1 05/09/18, 15:50 Completed build in 07m 02s on Wed, 9 May, 05:50 PM Test Summary: 493 of 30608 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23245
-
TYPO3com voted on patch set 4 V +1 05/09/18, 15:54 Completed build in 06m 02s on Wed, 9 May, 05:54 PM Test Summary: 31003 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23247
-
Mathias Brodala commented on patch set 4 V +1 CR +1 05/09/18, 15:56
Verified by Bamboo. -
Mathias Schreiber voted on patch set 4 V +1 CR +1 05/10/18, 09:57
-
Susi Moog voted on patch set 4 V +2 CR +2 05/10/18, 10:14
-
Susi Moog merged patch set 5 05/10/18, 10:14
ObjectManager.php:94