Review main Abandoned

56908[TASK] Remove unused constants regarding typo3.org

Benni Mack CR 0 V 0 Easy +1 −12 updated 05/13/18, 19:45

Commit message

TYPO3_URL_MAILINGLISTS
TYPO3_URL_DOCUMENTATION
TYPO3_URL_DOCUMENTATION_TSREF
TYPO3_URL_DOCUMENTATION_TSCONFIG
TYPO3_URL_CONSULTANCY
TYPO3_URL_CONTRIBUTE
TYPO3_URL_SECURITY
TYPO3_URL_DOWNLOAD
TYPO3_URL_SYSTEMREQUIREMENTS
TYPO3_URL_DONATE

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 56

  1. Benni Mack uploaded patch set 1 05/10/18, 15:53

  2. TYPO3com voted on patch set 1 V +1 05/10/18, 16:00 Completed build in 07m 18s on Thu, 10 May, 06:00 PM Test Summary: 31003 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23278

  3. Tymoteusz Motylewski commented on patch set 1 CR -1 05/10/18, 16:17

    This should be marked as breaking and handled by extension scanner, shouldn't it?
  4. Benni Mack commented on patch set 1 05/11/18, 05:01

    good point, as it's breaking and no way around that, let's remove them with 10.0 (to avoid unnecessary breaking changes for 9.x). I'll abandon the patch and restore it for 10.0 again.
  5. Benni Mack abandoned the change 05/11/18, 05:01

  6. Tymoteusz Motylewski commented on patch set 1 05/13/18, 19:45

    well, I expect that these constants are not really used in extensions and can be easily detected. So personally I'm ok for removing them in v9.