Review main Merged

56909[BUGFIX] Enforce int for timestamp on DateTime mapping

Nicole Hummel CR +2 V +2 Easy +1 −1 updated 05/10/18, 20:10

Commit message

This patch ensures using an integer value for turning a timestamp
to a DateTime object as otherwise a PHP error is thrown.

Review

  • Code review CR +2
    • Markus Klein +2
    • Helmut Hummel +1
  • Verified V +2
    • Markus Klein +2
    • Helmut Hummel +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Nicole Hummel uploaded patch set 1 05/10/18, 16:53

  2. TYPO3com voted on patch set 1 V +1 05/10/18, 17:02 Completed build in 08m 36s on Thu, 10 May, 07:02 PM Test Summary: 31003 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23279

  3. Helmut Hummel voted on patch set 1 V +1 CR +1 05/10/18, 19:17

  4. Markus Klein voted on patch set 1 V +2 CR +2 05/10/18, 20:09

  5. Markus Klein merged patch set 2 05/10/18, 20:09

  6. Markus Klein commented on patch set 2 05/10/18, 20:10

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit afdad9b8aad0e7bf8feaf379e6692aa4f5897b18