Review main Merged

56910[BUGFIX] Evaluate config.ftu earlier in a FE request

Benni Mack CR +2 V +2 Easy +2 −1 updated 05/10/18, 17:41

Commit message

The TypoScript option config.ftu is used to transfer a
session via GET parameters.

However this option is - unlike other TypoScript settings
- evaluted later in a frontend request. This makes it
impossible to use the option during various hooks, where
redirect URLs are generated.

Moving this evaluation to the same place as other TypoScript
options solves the issue.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Oliver Hader +1
    • Susi Moog +1
  • Verified V +2
    • Christian Kuhn +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 67

  1. Benni Mack uploaded patch set 1 05/10/18, 16:54

  2. TYPO3com voted on patch set 1 V +1 05/10/18, 17:04 Completed build in 09m 33s on Thu, 10 May, 07:04 PM Test Summary: 31003 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23280

  3. Oliver Hader voted on patch set 1 CR +1 05/10/18, 17:05

  4. Susi Moog voted on patch set 1 CR +1 05/10/18, 17:10

  5. Susi Moog voted on patch set 1 V +1 05/10/18, 17:15

  6. Christian Kuhn voted on patch set 1 V +2 CR +2 05/10/18, 17:41

  7. Christian Kuhn merged patch set 2 05/10/18, 17:41