56919[TASK] Various cleanups regarding comments and API calls
Commit message
Review
-
Code review CR +2
- Frank Nägler +2
- Mathias Schreiber +1
-
Verified V +2
- Frank Nägler +2
- Mathias Schreiber +1
- TYPO3com +1 CI
Issues 1
Files 5
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+2 −4
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+2 −2
- typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+2 −6
- typo3/sysext/frontend/Classes/Typolink/AbstractTypolinkBuilder.php+3 −5
Review log 810
-
Benni Mack uploaded patch set 1 05/11/18, 05:38
-
Andreas Kienast voted on patch set 1 CR +1 05/11/18, 05:43
-
TYPO3com voted on patch set 1 V -1 05/11/18, 05:46 Completed build in 07m 49s on Fri, 11 May, 07:46 AM Test Summary: 6 of 31250 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23306
-
Benni Mack commented on patch set 1 05/11/18, 07:04
see https://review.typo3.org/#/c/56920/ -
Benni Mack uploaded patch set 2 05/11/18, 07:46
-
Frank Nägler voted on patch set 2 V +1 CR +1 05/11/18, 07:54
-
TYPO3com voted on patch set 2 V +1 05/11/18, 07:55 Completed build in 08m 54s on Fri, 11 May, 09:55 AM Test Summary: 31003 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23308
-
Mathias Schreiber voted on patch set 2 V +1 CR +1 05/11/18, 07:56
-
Frank Nägler voted on patch set 2 V +2 CR +2 05/11/18, 08:08
-
Frank Nägler merged patch set 3 05/11/18, 08:08