Review main Merged

56919[TASK] Various cleanups regarding comments and API calls

Benni Mack CR +2 V +2 Easy +10 −18 updated 05/11/18, 08:08

Commit message

This patch is a small summary of clean ups in various
places of TYPO3 Core.

- EditDocumentController can be simplified to retrieve the closeUrl()
- Comment adaptions in GeneralUtility
- Comment adaptions and code simplification in ContentObjectRenderer
- HMENU debug option can be fetched from TSFE TypoScript directly
- TypoLinkBuilder can use "TSFE->initTemplate()" directly
  to instantiate the TemplateService, and should hand over
  proper values in the constructor.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Mathias Schreiber +1
  • Verified V +2
    • Frank Nägler +2
    • Mathias Schreiber +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 810

  1. Benni Mack uploaded patch set 1 05/11/18, 05:38

  2. Andreas Kienast voted on patch set 1 CR +1 05/11/18, 05:43

  3. TYPO3com voted on patch set 1 V -1 05/11/18, 05:46 Completed build in 07m 49s on Fri, 11 May, 07:46 AM Test Summary: 6 of 31250 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23306

  4. Benni Mack commented on patch set 1 05/11/18, 07:04

  5. Benni Mack uploaded patch set 2 05/11/18, 07:46

  6. Frank Nägler voted on patch set 2 V +1 CR +1 05/11/18, 07:54

  7. TYPO3com voted on patch set 2 V +1 05/11/18, 07:55 Completed build in 08m 54s on Fri, 11 May, 09:55 AM Test Summary: 31003 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23308

  8. Mathias Schreiber voted on patch set 2 V +1 CR +1 05/11/18, 07:56

  9. Frank Nägler voted on patch set 2 V +2 CR +2 05/11/18, 08:08

  10. Frank Nägler merged patch set 3 05/11/18, 08:08