Review main Merged

56920[BUGFIX] Migrate cObject to LoggerAwareTrait

Benni Mack CR +2 V +2 Easy +12 −31 updated 05/11/18, 07:49

Commit message

TYPO3 Core supports PSR-3 through the LoggerAwareTrait and LoggerAwareInterface
since TYPO3 v9 in all available PHP classes via makeInstance() automatically.

However, during the migration, ContentObjectRenderer was not replaced.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Mathias Schreiber +1
  • Verified V +2
    • Frank Nägler +2
    • Mathias Schreiber +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 56

  1. Benni Mack uploaded patch set 1 05/11/18, 07:03

  2. TYPO3com voted on patch set 1 V +1 05/11/18, 07:12 Completed build in 09m 03s on Fri, 11 May, 09:12 AM Test Summary: 31003 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23307

  3. Mathias Schreiber voted on patch set 1 V +1 CR +1 05/11/18, 07:28

  4. Frank Nägler voted on patch set 1 CR +1 05/11/18, 07:47

  5. Frank Nägler voted on patch set 1 V +2 CR +2 05/11/18, 07:49

  6. Frank Nägler merged patch set 2 05/11/18, 07:49