Review main Merged

56921[TASK] Cleanup TypeScript type defintions and editorconfig

Frank Nägler CR +2 V +2 Normal +30 −32 updated 05/12/18, 23:33

Commit message

Review

  • Code review CR +2
    • Markus Klein +2
    • Mathias Schreiber +1
  • Verified V +2
    • Markus Klein +2
    • Mathias Schreiber +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 89

  1. Frank Nägler uploaded patch set 1 05/11/18, 09:28

  2. TYPO3com voted on patch set 1 V +1 05/11/18, 09:36 Completed build in 08m 06s on Fri, 11 May, 11:36 AM Test Summary: 31003 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23312

  3. Mathias Schreiber voted on patch set 1 V +1 CR +1 05/11/18, 09:39

  4. Markus Klein voted on patch set 1 V +2 CR +2 05/11/18, 10:17

  5. Markus Klein merged patch set 2 05/11/18, 10:17

  6. Frank Nägler commented on patch set 2 05/12/18, 19:23

    post -1, this patch breaks creating file references in e.g. content elements. I have no idea why, but will investigate it.
  7. Markus Klein commented on patch set 2 05/12/18, 22:14

    I think I got it. We now require jsfunc.inline as AMD module, which does not make sense. before it was only declared as module in the TS type system.
  8. Markus Klein commented on patch set 2 05/12/18, 22:14

    DragUploader.ts:23

    this is wrong I would say
  9. Frank Nägler commented on patch set 2 05/12/18, 23:33

    The fix already merged: https://review.typo3.org/#/c/56946/