Review TYPO3_8-7 Merged

56924[BUGFIX] Compatibility for finishers which set content into the response

Susi Moog CR +2 V +2 Easy +7 −0 updated 05/11/18, 14:53

Commit message

Since #83822 EXT:form makes usage of the controller context
response object which has impacts to the finisher logic which was not
treated by #83822.
Since #84495, finishers with output can return this as string instead
of setting this directly into the response
(which results in a double output).
This patch ensures that existing custom finishers which set the content
into the response, get respected.

Review

  • Code review CR +2
    • Susi Moog +2
  • Verified V +2
    • Susi Moog +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Susi Moog commented on patch set 1 05/11/18, 14:01

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 05/11/18, 14:11 Completed build in 10m 15s on Fri, 11 May, 04:11 PM Test Summary: 58268 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2411

  3. Susi Moog commented on patch set 1 V +2 CR +2 05/11/18, 14:53

    straight backport.
  4. Susi Moog merged patch set 2 05/11/18, 14:53