Review main Merged

56933[TASK] Deprecate BackendUserAuthentication->addTScomment()

Christian Kuhn CR +2 V +2 Normal +49 −7 updated 05/12/18, 12:43

Commit message

addTScomment() adds comment strings to user TSconfig before
parse time. This is rather useless since the unparsed final
TSconfig is never shown in the backend. The patch removes
usages and deprecates the method to reduce complexity of
this huge class a tiny little bit.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Anja Leichsenring +1
  • Verified V +2
    • Wouter Wolters +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1014

  1. Christian Kuhn uploaded patch set 1 05/12/18, 12:17

  2. Christian Kuhn updated the commit message in patch set 2 05/12/18, 12:17

  3. Anja Leichsenring updated the commit message in patch set 3 05/12/18, 12:19

  4. Anja Leichsenring voted on patch set 3 V +1 CR +1 05/12/18, 12:20

  5. Wouter Wolters voted on patch set 3 CR +1 05/12/18, 12:22

  6. Christian Kuhn updated the commit message in patch set 4 05/12/18, 12:25

  7. Anja Leichsenring voted on patch set 4 V +1 CR +1 05/12/18, 12:25

  8. TYPO3com voted on patch set 1 V +1 05/12/18, 12:27 Completed build in 10m 04s on Sat, 12 May, 02:27 PM Test Summary: 31114 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23358

  9. TYPO3com voted on patch set 2 V +1 05/12/18, 12:27 Completed build in 09m 51s on Sat, 12 May, 02:27 PM Test Summary: 31114 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23359

  10. TYPO3com voted on patch set 3 V +1 05/12/18, 12:29 Completed build in 09m 34s on Sat, 12 May, 02:29 PM Test Summary: 31114 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23360

  11. TYPO3com voted on patch set 4 V +1 05/12/18, 12:30 Completed build in 05m 31s on Sat, 12 May, 02:30 PM Test Summary: 31114 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23361

  12. Wouter Wolters voted on patch set 4 CR +1 05/12/18, 12:31

  13. Wouter Wolters voted on patch set 4 V +2 CR +2 05/12/18, 12:43

  14. Wouter Wolters merged patch set 5 05/12/18, 12:43