Review main Merged

56937[TASK] Return full userTS in getTSConfig()

Christian Kuhn CR +2 V +2 Easy +7 −2 updated 05/12/18, 14:34

Commit message

By making the first argument $objectString optional in
BackendUserAuthentication->userTSConfig(), we allow the method to
act as a true getter that returns the full user TSconfig array.

This avoids calls to the public property ->userTS, which will be set
to protected in master with another patch.

This patch request is for both master and v8 to simplify life of
extension developers who want to keep an extension compatible
with v8 and v9, without throwing deprecations in v9.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
    • Anja Leichsenring +1
  • Verified V +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Christian Kuhn uploaded patch set 1 05/12/18, 14:23

  2. Anja Leichsenring voted on patch set 1 V +1 CR +1 05/12/18, 14:24

  3. TYPO3com voted on patch set 1 V +1 05/12/18, 14:32 Completed build in 08m 37s on Sat, 12 May, 04:32 PM Test Summary: 31114 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23374

  4. Mathias Schreiber voted on patch set 1 V +1 CR +1 05/12/18, 14:33

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 05/12/18, 14:34

  6. Christian Kuhn merged patch set 2 05/12/18, 14:34

  7. Christian Kuhn commented on patch set 2 05/12/18, 14:34

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit f637f1b2d777a139f14433cff0829f8d173310b1