Review TYPO3_8-7 Merged

56938[TASK] Return full userTS in getTSConfig()

Christian Kuhn CR +2 V +2 Easy +7 −2 updated 05/12/18, 14:53

Commit message

By making the first argument $objectString optional in
BackendUserAuthentication->userTSConfig(), we allow the method to
act as a true getter that returns the full user TSconfig array.

This avoids calls to the public property ->userTS, which will be set
to protected in master with another patch.

This patch request is for both master and v8 to simplify life of
extension developers who want to keep an extension compatible
with v8 and v9, without throwing deprecations in v9.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Christian Kuhn commented on patch set 1 05/12/18, 14:34

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 05/12/18, 14:48 Completed build in 14m 03s on Sat, 12 May, 04:48 PM Test Summary: 58268 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2426

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 05/12/18, 14:53

  4. Christian Kuhn merged patch set 2 05/12/18, 14:53