Review main Merged

56940[TASK] Protect user TSconfig properties in BackendUserAuthentication

Christian Kuhn CR +2 V +2 Normal +170 −67 updated 05/13/18, 17:51

Commit message

The patch sets all user TSconfig related properties of class
BackendUserAuthentication to protected. Existing usages of
property "userTS" are adapted to call getTSConfig() instead.

Review

  • Code review CR +2
    • Andreas Wolf +2
    • Anja Leichsenring +1
  • Verified V +2
    • Andreas Wolf +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 2

Files 14

Review log 1620

  1. Christian Kuhn uploaded patch set 1 05/12/18, 15:31

  2. Christian Kuhn updated the commit message in patch set 2 05/12/18, 15:32

  3. TYPO3com voted on patch set 1 V -1 05/12/18, 15:40 Completed build in 08m 35s on Sat, 12 May, 05:40 PM Test Summary: 123 of 31361 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23382

  4. TYPO3com voted on patch set 2 V -1 05/12/18, 15:42 Completed build in 09m 48s on Sat, 12 May, 05:42 PM Test Summary: 123 of 31361 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23383

  5. Mathias Schreiber commented on patch set 2 05/12/18, 15:47

    BackendUserAuthentication.php:144

    unparsed

    BackendUserAuthentication.php:149

    unparsed

    BackendUserAuthentication.php:1377

    i don't get these comments
  6. Christian Kuhn commented on patch set 2 05/12/18, 15:49

    BackendUserAuthentication.php:144 Reply Unresolved

    wilco

    BackendUserAuthentication.php:149 Reply Unresolved

    wilco

    BackendUserAuthentication.php:1377 Reply Unresolved

    the property will be removed in v10. this is just a hint we don't forget this removal / code adaption if the property is kicked in v10 since we'll stumble upon that code line if grepping for @deprecated, too.
  7. Christian Kuhn voted on patch set 2 CR -1 05/12/18, 16:07

  8. Christian Kuhn uploaded patch set 3 05/12/18, 16:54

  9. TYPO3com voted on patch set 3 V +1 05/12/18, 17:02 Completed build in 07m 51s on Sat, 12 May, 07:02 PM Test Summary: 31114 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23388

  10. Anja Leichsenring voted on patch set 3 V +1 CR +1 05/12/18, 19:27

  11. Andreas Wolf commented on patch set 4 05/13/18, 08:01

    Published edit on patch set 3.
  12. TYPO3com voted on patch set 4 V +1 05/13/18, 08:09 Completed build in 07m 48s on Sun, 13 May, 10:09 AM Test Summary: 31111 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23420

  13. Andreas Wolf voted on patch set 4 V +1 CR +1 05/13/18, 08:24

  14. Anja Leichsenring voted on patch set 4 V +1 CR +1 05/13/18, 08:25

  15. Andreas Wolf voted on patch set 4 V +2 CR +2 05/13/18, 08:25

  16. Andreas Wolf merged patch set 5 05/13/18, 08:25

  17. Nicole Hummel commented on patch set 5 05/13/18, 09:34

    Post -1 This patch is not (only) a deprecation, it is a breaking change. IMHO we need to add a proper breaking rst file here!
  18. Nicole Hummel commented on patch set 5 05/13/18, 09:35

    BackendUserAuthentication.php:1890

    Why does the BackendUserAuthentification class needs to call the getter method here? Accessing its own protected properties should be working, don't it?

    BackendUserAuthentication.php:1919

    Why does the BackendUserAuthentification class needs to call the getter method here?
  19. Nicole Hummel commented on patch set 5 05/13/18, 09:49

    I see. PublicPropertyDeprecationTrait is still about to returning the property. But it shouldn't be called for protected properties inside the class, is it?
  20. Christian Kuhn commented on patch set 5 05/13/18, 17:51

    BackendUserAuthentication.php:1890 Reply

    that was easier to mock in tests.