56940[TASK] Protect user TSconfig properties in BackendUserAuthentication
Commit message
Review
-
Code review CR +2
- Andreas Wolf +2
- Anja Leichsenring +1
-
Verified V +2
- Andreas Wolf +2
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 2
Files 14
- typo3/sysext/backend/Classes/Form/FormDataProvider/UserTsConfig.php+1 −1
- typo3/sysext/backend/Classes/Toolbar/ClearCacheActionsHookInterface.php+1 −1
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+1 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/UserTsConfigTest.php+4 −2
- typo3/sysext/backend/Tests/Unit/Utility/BackendUtilityTest.php+1 −1
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php9+31 −18
- typo3/sysext/core/Classes/Database/QueryGenerator.php+8 −7
- typo3/sysext/core/Classes/Database/QueryView.php+4 −3
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-84984-ProtectedUserTSconfigPropertiesInBackendUserAuthentication.rstnew+44 −0
- typo3/sysext/core/Tests/Unit/Authentication/BackendUserAuthenticationTest.php+42 −33
- typo3/sysext/extbase/Tests/Functional/Persistence/Generic/Mapper/DataMapperTest.php+3 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/AddTest.php+2 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/RelationTest.php+3 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/PropertyProtectedMatcher.php+25 −0
Review log 1620
-
Christian Kuhn uploaded patch set 1 05/12/18, 15:31
-
Christian Kuhn updated the commit message in patch set 2 05/12/18, 15:32
-
TYPO3com voted on patch set 1 V -1 05/12/18, 15:40 Completed build in 08m 35s on Sat, 12 May, 05:40 PM Test Summary: 123 of 31361 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23382
-
TYPO3com voted on patch set 2 V -1 05/12/18, 15:42 Completed build in 09m 48s on Sat, 12 May, 05:42 PM Test Summary: 123 of 31361 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23383
-
Mathias Schreiber commented on patch set 2 05/12/18, 15:47
BackendUserAuthentication.php:149unparsedBackendUserAuthentication.php:1377i don't get these comments -
Christian Kuhn commented on patch set 2 05/12/18, 15:49
BackendUserAuthentication.php:144Reply UnresolvedwilcoBackendUserAuthentication.php:149Reply UnresolvedwilcoBackendUserAuthentication.php:1377Reply Unresolvedthe property will be removed in v10. this is just a hint we don't forget this removal / code adaption if the property is kicked in v10 since we'll stumble upon that code line if grepping for @deprecated, too. -
Christian Kuhn voted on patch set 2 CR -1 05/12/18, 16:07
-
Christian Kuhn uploaded patch set 3 05/12/18, 16:54
-
TYPO3com voted on patch set 3 V +1 05/12/18, 17:02 Completed build in 07m 51s on Sat, 12 May, 07:02 PM Test Summary: 31114 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23388
-
Anja Leichsenring voted on patch set 3 V +1 CR +1 05/12/18, 19:27
-
Andreas Wolf commented on patch set 4 05/13/18, 08:01
Published edit on patch set 3. -
TYPO3com voted on patch set 4 V +1 05/13/18, 08:09 Completed build in 07m 48s on Sun, 13 May, 10:09 AM Test Summary: 31111 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23420
-
Andreas Wolf voted on patch set 4 V +1 CR +1 05/13/18, 08:24
-
Anja Leichsenring voted on patch set 4 V +1 CR +1 05/13/18, 08:25
-
Andreas Wolf voted on patch set 4 V +2 CR +2 05/13/18, 08:25
-
Andreas Wolf merged patch set 5 05/13/18, 08:25
-
Nicole Hummel commented on patch set 5 05/13/18, 09:34
Post -1 This patch is not (only) a deprecation, it is a breaking change. IMHO we need to add a proper breaking rst file here! -
Nicole Hummel commented on patch set 5 05/13/18, 09:35
BackendUserAuthentication.php:1890Why does the BackendUserAuthentification class needs to call the getter method here? Accessing its own protected properties should be working, don't it?BackendUserAuthentication.php:1919Why does the BackendUserAuthentification class needs to call the getter method here? -
Nicole Hummel commented on patch set 5 05/13/18, 09:49
I see. PublicPropertyDeprecationTrait is still about to returning the property. But it shouldn't be called for protected properties inside the class, is it? -
Christian Kuhn commented on patch set 5 05/13/18, 17:51
BackendUserAuthentication.php:1890Replythat was easier to mock in tests.
BackendUserAuthentication.php:144