Review main Merged

56944[BUGFIX] Fix basename-fetch in basenameDuringBootstrap

Stefan Neufeind CR +2 V +2 Normal +79 −1 updated 05/13/18, 09:50

Commit message

Also add tests for dirnameDuringBootstrap and basenameDuringBootstrap.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Andreas Wolf +1
  • Verified V +2
    • Christian Kuhn +2
    • Andreas Wolf +1
    • TYPO3com +1 CI

Issues 2

Files 2

Review log 811

  1. Stefan Neufeind uploaded patch set 1 05/12/18, 18:52

  2. TYPO3com voted on patch set 1 V +1 05/12/18, 19:01 Completed build in 09m 18s on Sat, 12 May, 09:01 PM Test Summary: 31138 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23392

  3. Stefan Neufeind commented on patch set 1 05/12/18, 19:06

    @Lolli: Thanks for requesting tests as part of https://review.typo3.org/47169 And imho the basename-fetching doesn't work as expected so far.
  4. Stefan Neufeind uploaded patch set 2 05/12/18, 20:19

  5. Stefan Neufeind commented on patch set 2 05/12/18, 20:20

    PathUtility.php:292

    Issue why the current solution does not work is that the last part matches correctly - and is replaced by $1 But the rest is left untouched - and still part of the result.
  6. TYPO3com voted on patch set 2 V +1 05/12/18, 20:28 Completed build in 09m 10s on Sat, 12 May, 10:28 PM Test Summary: 31138 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23396

  7. Christian Kuhn updated the commit message in patch set 3 05/13/18, 08:27

  8. TYPO3com voted on patch set 3 V +1 05/13/18, 08:36 Completed build in 09m 25s on Sun, 13 May, 10:36 AM Test Summary: 31135 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23423

  9. Andreas Wolf voted on patch set 3 V +1 CR +1 05/13/18, 09:26

  10. Christian Kuhn voted on patch set 3 V +2 CR +2 05/13/18, 09:50

  11. Christian Kuhn merged patch set 4 05/13/18, 09:50