Review main Merged

56949[BUGFIX] Allow direct access to BE again while being logged in

Markus Klein CR +2 V +2 Easy +3 −31 updated 05/13/18, 07:47

Commit message

Having a valid backend authentication and accessing /typo3
now redirects to the backend view again.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Andreas Wolf +2
    • Anja Leichsenring +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1419

  1. Markus Klein uploaded patch set 1 05/12/18, 21:16

  2. Christian Kuhn updated the commit message in patch set 2 05/12/18, 21:21

  3. Christian Kuhn uploaded patch set 3 05/12/18, 21:26

  4. TYPO3com voted on patch set 1 V -1 05/12/18, 21:27 Completed build in 10m 37s on Sat, 12 May, 11:27 PM Test Summary: 3 of 31361 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23403

  5. Christian Kuhn voted on patch set 3 V +1 CR +1 05/12/18, 21:27

  6. TYPO3com voted on patch set 2 V -1 05/12/18, 21:33 Completed build in 11m 34s on Sat, 12 May, 11:33 PM Test Summary: 3 of 31361 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23405

  7. TYPO3com voted on patch set 3 V -1 05/12/18, 21:37 Completed build in 11m 04s on Sat, 12 May, 11:37 PM Test Summary: 3 of 31361 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23407

  8. Anja Leichsenring voted on patch set 3 V +1 CR +1 05/12/18, 21:39

  9. Helmut Hummel commented on patch set 3 05/12/18, 21:40

    LoginController.php:310

    besides the unit test failure. can you explain why the other conditions can be removed?
  10. Markus Klein commented on patch set 3 05/12/18, 21:48

    will fix the tests and will add the explanation to forge
  11. Markus Klein uploaded patch set 4 05/12/18, 22:00

  12. TYPO3com voted on patch set 4 V +1 05/12/18, 22:09 Completed build in 09m 03s on Sun, 13 May, 12:09 AM Test Summary: 31111 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23413

  13. Anja Leichsenring voted on patch set 4 V +1 CR +1 05/13/18, 06:24

  14. Anja Leichsenring rebased onto patch set 5 05/13/18, 06:52

  15. Anja Leichsenring commented on patch set 5 V +1 CR +1 05/13/18, 06:53

    sorry for the rebase. Happend because of dependency to my current work. No changes done.
  16. TYPO3com voted on patch set 5 V +1 05/13/18, 07:00 Completed build in 08m 15s on Sun, 13 May, 09:00 AM Test Summary: 31111 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23417

  17. Andreas Wolf voted on patch set 5 CR +2 05/13/18, 07:46

  18. Christian Kuhn voted on patch set 5 V +2 CR +2 05/13/18, 07:47

  19. Christian Kuhn merged patch set 6 05/13/18, 07:47