Review main Merged

56953[TASK] Deprecate getTSConfigVal() and getTSConfigProp()

Christian Kuhn CR +2 V +2 Hard +383 −270 updated 11/08/18, 19:29

Commit message

The patch deprecates BackendUserAuthentication->getTSConfigVal()
and ->getTSConfigProp() and adapts usages to rely on getTSConfig()
without arguments. The array nesting is done directly within
consuming code and is combined with ?? to a fallback value.
Advantages:
* Expensive and recursive string operations within
  getTSConfig() are not used anymore.
* The weird 'value' / 'property' based sub array
  juggling is gone.
* Full TSconfig path including fallback can be easily
  seen within consuming code
* Notice free array access using null coalescence operator

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Stefan Neufeind +1
    • Anja Leichsenring +1
  • Verified V +2
    • Wouter Wolters +2
    • Stefan Neufeind +1
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 2

Files 55

Show 35 more files

Review log 2535

Show 610 earlier messages
  1. Christian Kuhn uploaded patch set 1 05/13/18, 12:17

  2. Christian Kuhn voted on patch set 1 CR -2 05/13/18, 12:17

  3. TYPO3com voted on patch set 1 V -1 05/13/18, 12:26 Completed build in 09m 09s on Sun, 13 May, 02:26 PM Test Summary: 448 of 31400 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23434

  4. Christian Kuhn uploaded patch set 2 05/13/18, 12:39

  5. TYPO3com voted on patch set 2 V +1 05/13/18, 12:49 Completed build in 09m 21s on Sun, 13 May, 02:49 PM Test Summary: 31153 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23436

  6. Christian Kuhn uploaded patch set 3 05/13/18, 12:53

  7. TYPO3com voted on patch set 3 V +1 05/13/18, 13:02 Completed build in 08m 47s on Sun, 13 May, 03:02 PM Test Summary: 31153 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23437

  8. Christian Kuhn uploaded patch set 4 05/13/18, 14:23

  9. TYPO3com voted on patch set 4 V -1 05/13/18, 14:31 Completed build in 08m 24s on Sun, 13 May, 04:31 PM Test Summary: 15 of 31400 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23439

  10. Christian Kuhn uploaded patch set 5 05/13/18, 15:38

  1. TYPO3com voted on patch set 5 V +1 05/13/18, 15:47 Completed build in 08m 49s on Sun, 13 May, 05:47 PM Test Summary: 31153 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23442

  2. Christian Kuhn uploaded patch set 6 05/13/18, 16:12

  3. TYPO3com voted on patch set 6 V +1 05/13/18, 16:20 Completed build in 07m 45s on Sun, 13 May, 06:20 PM Test Summary: 31153 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23443

  4. Christian Kuhn uploaded patch set 7 05/13/18, 17:49

  5. Christian Kuhn voted on patch set 7 CR 0 05/13/18, 17:55

  6. Anja Leichsenring updated the commit message in patch set 8 05/13/18, 17:57

  7. TYPO3com voted on patch set 7 V +1 05/13/18, 17:59 Completed build in 09m 45s on Sun, 13 May, 07:59 PM Test Summary: 31153 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23444

  8. TYPO3com voted on patch set 8 V +1 05/13/18, 18:05 Completed build in 07m 50s on Sun, 13 May, 08:05 PM Test Summary: 31153 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23446

  9. Christian Kuhn commented on patch set 8 05/13/18, 18:26

    DocumentController.php:147

    that's broken.

    DocumentController.php:151

    that, too.
  10. Wouter Wolters commented on patch set 8 05/13/18, 18:39

    BackendUserAuthentication.php:1246

    needs deprecation message

    BackendUserAuthentication.php:1259

    needs deprecation message
  11. Christian Kuhn uploaded patch set 9 05/13/18, 18:52

  12. TYPO3com voted on patch set 9 V +1 05/13/18, 19:01 Completed build in 08m 48s on Sun, 13 May, 09:01 PM Test Summary: 31153 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23449

  13. Wouter Wolters voted on patch set 9 V +1 CR +1 05/13/18, 19:05

  14. Stefan Neufeind commented on patch set 9 05/13/18, 19:09

    RecordProvider.php:464

    We still need "properties" in there, don't we?
  15. Anja Leichsenring voted on patch set 9 V +1 CR +1 05/13/18, 19:13

  16. Christian Kuhn commented on patch set 9 CR -2 05/13/18, 19:14

    foo ... forgot the scanner matchers ... mom.

    BackendUserAuthentication.php:1246 Reply

    oops. thx!
  17. Christian Kuhn commented on patch set 9 05/13/18, 19:22

    RecordProvider.php:464 Reply

    no. the 'properties' and 'value' sub arrays are only added by getTSConfig() if you call it with arguments - which i'll deprecate soon, too.
  18. Christian Kuhn uploaded patch set 10 05/13/18, 19:28

  19. Christian Kuhn voted on patch set 10 CR 0 05/13/18, 19:29

  20. Anja Leichsenring voted on patch set 10 V +1 CR +1 05/13/18, 19:29

  21. Stefan Neufeind voted on patch set 10 V +1 CR +1 05/13/18, 19:33

  22. TYPO3com voted on patch set 10 V +1 05/13/18, 19:38 Completed build in 09m 14s on Sun, 13 May, 09:38 PM Test Summary: 31153 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23451

  23. Wouter Wolters voted on patch set 10 V +2 CR +2 05/13/18, 20:28

  24. Wouter Wolters merged patch set 11 05/13/18, 20:28

  25. Benni Mack commented on patch set 11 11/08/18, 19:29

    AbstractProvider.php:149

    here's a regression btw Fixing it here: https://review.typo3.org/#/c/58871/