56953[TASK] Deprecate getTSConfigVal() and getTSConfigProp()
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Stefan Neufeind +1
- Anja Leichsenring +1
-
Verified V +2
- Wouter Wolters +2
- Stefan Neufeind +1
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 2
Files 55
- typo3/sysext/adminpanel/Classes/Middleware/AdminPanelInitiator.php+1 −1
- typo3/sysext/adminpanel/Classes/Modules/AbstractModule.php+1 −1
- typo3/sysext/adminpanel/Classes/Modules/EditModule.php+2 −5
- typo3/sysext/backend/Classes/Backend/ToolbarItems/ClearCacheToolbarItem.php+8 −5
- typo3/sysext/backend/Classes/Backend/ToolbarItems/ShortcutToolbarItem.php+2 −2
- typo3/sysext/backend/Classes/Clipboard/Clipboard.php+3 −6
- typo3/sysext/backend/Classes/ContextMenu/ItemProviders/AbstractProvider.php1+5 −1
- typo3/sysext/backend/Classes/ContextMenu/ItemProviders/PageProvider.php+1 −1
- typo3/sysext/backend/Classes/ContextMenu/ItemProviders/RecordProvider.php2+2 −3
- typo3/sysext/backend/Classes/Controller/Page/NewMultiplePagesController.php+1 −1
- typo3/sysext/backend/Classes/Controller/Page/TreeController.php+11 −9
- typo3/sysext/backend/Classes/Controller/BackendController.php+4 −3
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+1 −1
- typo3/sysext/backend/Classes/Controller/LoginController.php+5 −4
- typo3/sysext/backend/Classes/Controller/NewRecordController.php+8 −9
- typo3/sysext/backend/Classes/Controller/SimpleDataHandlerController.php+1 −1
- typo3/sysext/backend/Classes/Domain/Repository/Module/BackendModuleRepository.php+31 −22
- typo3/sysext/backend/Classes/Form/FormResultCompiler.php+4 −4
- typo3/sysext/backend/Classes/Tree/View/AbstractTreeView.php+3 −1
- typo3/sysext/backend/Classes/Tree/View/BrowseTreeView.php+8 −4
Show 35 more files
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+7 −10
- typo3/sysext/backend/Classes/View/PageLayoutView.php+12 −10
- typo3/sysext/backend/Tests/Unit/Controller/LoginControllerTest.php+21 −3
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php3+17 −13
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+6 −3
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-84993-DeprecateSomeTSconfigRelatedMethods.rstnew+74 −0
- typo3/sysext/core/Tests/Unit/Authentication/BackendUserAuthenticationTest.php+20 −8
- typo3/sysext/documentation/Classes/Controller/DocumentController.php2+3 −4
- typo3/sysext/feedit/Classes/Middleware/FrontendEditInitiator.php+1 −1
- typo3/sysext/feedit/Classes/FrontendEditPanel.php+2 −2
- typo3/sysext/filelist/Classes/Controller/FileListController.php+11 −9
- typo3/sysext/form/Classes/Controller/FormEditorController.php+5 −7
- typo3/sysext/impexp/Classes/ContextMenu/ItemProvider.php+2 −7
- typo3/sysext/impexp/Classes/Controller/ImportExportController.php+2 −3
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+14 −0
- typo3/sysext/opendocs/Classes/Backend/ToolbarItems/OpendocsToolbarItem.php+2 −4
- typo3/sysext/recordlist/Classes/Browser/DatabaseBrowser.php+7 −8
- typo3/sysext/recordlist/Classes/Browser/FileBrowser.php+2 −2
- typo3/sysext/recordlist/Classes/Controller/AbstractLinkBrowserController.php+1 −4
- typo3/sysext/recordlist/Classes/LinkHandler/AbstractLinkHandler.php+2 −2
- typo3/sysext/recordlist/Classes/LinkHandler/FileLinkHandler.php+1 −1
- typo3/sysext/recordlist/Classes/LinkHandler/PageLinkHandler.php+4 −5
- typo3/sysext/recordlist/Classes/LinkHandler/RecordLinkHandler.php+4 −4
- typo3/sysext/recordlist/Classes/RecordList/AbstractDatabaseRecordList.php+3 −5
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+14 −17
- typo3/sysext/recordlist/Classes/View/FolderUtilityRenderer.php+14 −17
- typo3/sysext/recycler/Classes/Controller/RecyclerAjaxController.php+5 −6
- typo3/sysext/recycler/Classes/Controller/RecyclerModuleController.php+7 −6
- typo3/sysext/setup/Classes/Controller/SetupModuleController.php+2 −2
- typo3/sysext/taskcenter/Classes/Controller/TaskModuleController.php+5 −8
- typo3/sysext/viewpage/Classes/Controller/ViewModuleController.php+2 −7
- typo3/sysext/workspaces/Classes/Controller/Remote/MassActionHandler.php+5 −4
- typo3/sysext/workspaces/Classes/Controller/PreviewController.php+1 −1
- typo3/sysext/workspaces/Classes/DataHandler/CommandMap.php+2 −2
- typo3/sysext/workspaces/Classes/Preview/PreviewUriBuilder.php+1 −1
Review log 2535
Show 610 earlier messages
-
Christian Kuhn uploaded patch set 1 05/13/18, 12:17
-
Christian Kuhn voted on patch set 1 CR -2 05/13/18, 12:17
-
TYPO3com voted on patch set 1 V -1 05/13/18, 12:26 Completed build in 09m 09s on Sun, 13 May, 02:26 PM Test Summary: 448 of 31400 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23434
-
Christian Kuhn uploaded patch set 2 05/13/18, 12:39
-
TYPO3com voted on patch set 2 V +1 05/13/18, 12:49 Completed build in 09m 21s on Sun, 13 May, 02:49 PM Test Summary: 31153 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23436
-
Christian Kuhn uploaded patch set 3 05/13/18, 12:53
-
TYPO3com voted on patch set 3 V +1 05/13/18, 13:02 Completed build in 08m 47s on Sun, 13 May, 03:02 PM Test Summary: 31153 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23437
-
Christian Kuhn uploaded patch set 4 05/13/18, 14:23
-
TYPO3com voted on patch set 4 V -1 05/13/18, 14:31 Completed build in 08m 24s on Sun, 13 May, 04:31 PM Test Summary: 15 of 31400 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23439
-
Christian Kuhn uploaded patch set 5 05/13/18, 15:38
-
TYPO3com voted on patch set 5 V +1 05/13/18, 15:47 Completed build in 08m 49s on Sun, 13 May, 05:47 PM Test Summary: 31153 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23442
-
Christian Kuhn uploaded patch set 6 05/13/18, 16:12
-
TYPO3com voted on patch set 6 V +1 05/13/18, 16:20 Completed build in 07m 45s on Sun, 13 May, 06:20 PM Test Summary: 31153 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23443
-
Christian Kuhn uploaded patch set 7 05/13/18, 17:49
-
Christian Kuhn voted on patch set 7 CR 0 05/13/18, 17:55
-
Anja Leichsenring updated the commit message in patch set 8 05/13/18, 17:57
-
TYPO3com voted on patch set 7 V +1 05/13/18, 17:59 Completed build in 09m 45s on Sun, 13 May, 07:59 PM Test Summary: 31153 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23444
-
TYPO3com voted on patch set 8 V +1 05/13/18, 18:05 Completed build in 07m 50s on Sun, 13 May, 08:05 PM Test Summary: 31153 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23446
-
Christian Kuhn commented on patch set 8 05/13/18, 18:26
DocumentController.php:151that, too. -
Wouter Wolters commented on patch set 8 05/13/18, 18:39
BackendUserAuthentication.php:1246needs deprecation messageBackendUserAuthentication.php:1259needs deprecation message -
Christian Kuhn uploaded patch set 9 05/13/18, 18:52
-
TYPO3com voted on patch set 9 V +1 05/13/18, 19:01 Completed build in 08m 48s on Sun, 13 May, 09:01 PM Test Summary: 31153 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23449
-
Wouter Wolters voted on patch set 9 V +1 CR +1 05/13/18, 19:05
-
Stefan Neufeind commented on patch set 9 05/13/18, 19:09
RecordProvider.php:464We still need "properties" in there, don't we? -
Anja Leichsenring voted on patch set 9 V +1 CR +1 05/13/18, 19:13
-
Christian Kuhn commented on patch set 9 CR -2 05/13/18, 19:14
foo ... forgot the scanner matchers ... mom.BackendUserAuthentication.php:1246Replyoops. thx! -
Christian Kuhn commented on patch set 9 05/13/18, 19:22
RecordProvider.php:464Replyno. the 'properties' and 'value' sub arrays are only added by getTSConfig() if you call it with arguments - which i'll deprecate soon, too. -
Christian Kuhn uploaded patch set 10 05/13/18, 19:28
-
Christian Kuhn voted on patch set 10 CR 0 05/13/18, 19:29
-
Anja Leichsenring voted on patch set 10 V +1 CR +1 05/13/18, 19:29
-
Stefan Neufeind voted on patch set 10 V +1 CR +1 05/13/18, 19:33
-
TYPO3com voted on patch set 10 V +1 05/13/18, 19:38 Completed build in 09m 14s on Sun, 13 May, 09:38 PM Test Summary: 31153 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23451
-
Wouter Wolters voted on patch set 10 V +2 CR +2 05/13/18, 20:28
-
Wouter Wolters merged patch set 11 05/13/18, 20:28
-
Benni Mack commented on patch set 11 11/08/18, 19:29
AbstractProvider.php:149here's a regression btw Fixing it here: https://review.typo3.org/#/c/58871/
DocumentController.php:147