Review main Merged

56959[BUGFIX] Fix deletion of invalid tasks

Mathias Brodala CR +2 V +2 Easy +1 −1 updated 05/16/18, 09:29

Commit message

If the class of a registered task is missing, e.g. because the related
extension has been removed, the task itself will be unserialized into
an __PHP_Incomplete_Class object. Checking the task execution is an
invalid access in this case and must be avoided for such tasks to be
deleted.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Frank Nägler +1
    • Susi Moog +1
  • Verified V +2
    • Christian Kuhn +2
    • Frank Nägler +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1315

  1. Mathias Brodala uploaded patch set 1 05/14/18, 09:41

  2. Markus Klein voted on patch set 1 CR +1 05/14/18, 09:46

  3. TYPO3com voted on patch set 1 V +1 05/14/18, 09:49 Completed build in 07m 32s on Mon, 14 May, 11:49 AM Test Summary: 31180 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23475

  4. Oliver Klee commented on patch set 1 05/14/18, 09:53

    Scheduler.php:437

    Could we also use instanceof and ::class here, or does that not work with __PHP_Incomplete_Class?
  5. Mathias Brodala commented on patch set 1 05/14/18, 09:58

    Scheduler.php:437 Reply

    Actually that could work but in fact this whole check can be simplified.
  6. Mathias Brodala commented on patch set 2 05/14/18, 09:58

    Published edit on patch set 1.
  7. Mathias Brodala commented on patch set 2 05/14/18, 09:59

    Simplified check.
  8. Wouter Wolters voted on patch set 2 CR +1 05/14/18, 09:59

  9. TYPO3com voted on patch set 2 V +1 05/14/18, 10:07 Completed build in 08m 45s on Mon, 14 May, 12:07 PM Test Summary: 31180 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23476

  10. Christian Kuhn voted on patch set 2 V +1 CR +1 05/16/18, 09:28

  11. Frank Nägler voted on patch set 2 V +1 CR +1 05/16/18, 09:28

  12. Susi Moog voted on patch set 2 V +1 CR +1 05/16/18, 09:28

  13. Christian Kuhn voted on patch set 2 V +2 CR +2 05/16/18, 09:29

  14. Christian Kuhn merged patch set 3 05/16/18, 09:29

  15. Christian Kuhn commented on patch set 3 05/16/18, 09:29

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 3cd7c584aab464313873ed5d36efd123b9062763