Review TYPO3_8-7 Merged

56961[BUGFIX] do not override forceTypeValue if no pageType is set

Mathias Brodala CR +2 V +2 Easy +1 −1 updated 05/14/18, 15:00

Commit message

If a link doesn't set a pageType and
there is no target that defines a pageType,
then forceTypeValue needs to be used instead of always
assuming a pageType of 0.

With this fix, it is possible to actually use
the TypoScript option config.forceTypeValue again.

Review

  • Code review CR +2
    • Mathias Brodala +2
  • Verified V +2
    • Mathias Brodala +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Mathias Brodala commented on patch set 1 05/14/18, 14:46

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 05/14/18, 14:58 Completed build in 12m 21s on Mon, 14 May, 04:58 PM Test Summary: 58280 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2454

  3. Mathias Brodala voted on patch set 1 V +2 CR +2 05/14/18, 15:00

  4. Mathias Brodala merged patch set 2 05/14/18, 15:00