Review main Merged

56962[BUGFIX] Use better icons for backend layout grid editor actions

Mathias Brodala CR +2 V +2 Easy +6 −6 updated 05/18/18, 13:56

Commit message

Review

  • Code review CR +2
    • Frank Nägler +2
    • Riccardo De Contardi +1
  • Verified V +2
    • Frank Nägler +2
    • Riccardo De Contardi +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 89

  1. Mathias Brodala uploaded patch set 1 05/15/18, 08:02

  2. TYPO3com voted on patch set 1 V +1 05/15/18, 08:10 Completed build in 08m 27s on Tue, 15 May, 10:10 AM Test Summary: 31184 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23493

  3. Riccardo De Contardi voted on patch set 1 V +1 CR +1 05/17/18, 20:04

  4. Markus Klein commented on patch set 1 CR -1 05/17/18, 20:31

    I'm not sure about this change. The arrows give a better impression where stuff is added
  5. Mathias Brodala commented on patch set 1 05/18/18, 06:55

    > I'm not sure about this change. > The arrows give a better impression where stuff is added Not really. They indicate that you can move around columns and rows, since that's what arrow icons are there for. See the sorting in TYPO3 for example. Of course, dedicated icons for column/row addition/removal would be better here but until we have such icons, the well known plus/minus icons better convey the purpose of the actions here.
  6. Markus Klein commented on patch set 1 CR 0 05/18/18, 12:42

    okay, I stay neutral here. I'm not fully against it, neither fully for it
  7. Frank Nägler voted on patch set 1 V +2 CR +2 05/18/18, 13:56

  8. Frank Nägler merged patch set 2 05/18/18, 13:56

  9. Frank Nägler commented on patch set 2 05/18/18, 13:56

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit a05fc38cc2e92bd817cd9244bc4277fd35ac74bc