Review main Merged

56968[TASK] Streamline TSconfig API

Christian Kuhn CR +2 V +2 Expert +656 −493 updated 05/18/18, 09:49

Commit message

Final patch to de-mess the user / page TSconfig related API.

Page TSconfig can be overriden in user TSconfig by prefixing the
path with 'page.' in user TSconfig. However, method
BackendUtility::getModTSconfig() violated this principle and
had a special merge strategy that allowed ommitting the 'page.'
prefix. This has been marked as deprecated in the TSconfig docs for
various years and has been lately removed in the docs altogether,
but the code still existed.
The patch moves this merge into BackendUtility::getPagesTSconfig()
and properly deprecates this case. Usages of getModTSconfig() are
changed to use getPagesTSconfig() directly, dropping the artificial
'properties' and 'value' sub arrays and omitting some rather expensive
string operations at the same time.
This obsoletes getModTSconfig() and a couple of related methods.

Additionally, BackendUserAuthentication->getTSConfig() has been
abused frequently to operate on different arrays than it's own userTS.
Those usages are dropped with the patch. Handing over arguments to
getTSConfig() is now deprecated, effectively reducing the method a getter.

This reduces the API down to BackendUtility::getPagesTSconfig($pid)
and BackendUserAuhtentiction->getTSConfig() both just returning the
entire array. This simplified API can now be documented in the docs.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Jan Helke +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Jan Helke +1
    • TYPO3com +1 CI

Issues 2

Files 43

Show 23 more files

Review log 1218

  1. Christian Kuhn uploaded patch set 1 05/15/18, 12:26

  2. TYPO3com voted on patch set 1 V +1 05/15/18, 12:35 Completed build in 08m 52s on Tue, 15 May, 02:35 PM Test Summary: 31185 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23509

  3. Christian Kuhn uploaded patch set 2 05/15/18, 13:32

  4. TYPO3com voted on patch set 2 V -1 05/15/18, 13:41 Completed build in 08m 50s on Tue, 15 May, 03:41 PM Test Summary: 78 of 31432 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23513

  5. Christian Kuhn uploaded patch set 3 05/15/18, 13:51

  6. TYPO3com voted on patch set 3 V -1 05/15/18, 14:00 Completed build in 09m 02s on Tue, 15 May, 04:00 PM Test Summary: 39 of 31432 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23515

  7. Christian Kuhn uploaded patch set 4 05/15/18, 15:25

  8. Christian Kuhn uploaded patch set 5 05/15/18, 15:31

  9. TYPO3com voted on patch set 4 V -1 05/15/18, 15:33 Completed build in 07m 56s on Tue, 15 May, 05:33 PM Test Summary: 39 of 31432 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23519

  10. TYPO3com voted on patch set 5 V +1 05/15/18, 15:39 Completed build in 07m 51s on Tue, 15 May, 05:39 PM Test Summary: 31159 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23520

  11. Jan Helke voted on patch set 5 V +1 CR +1 05/15/18, 16:47

  12. Susi Moog updated the commit message in patch set 6 05/16/18, 07:48

  13. TYPO3com voted on patch set 6 V +1 05/16/18, 07:56 Completed build in 08m 06s on Wed, 16 May, 09:56 AM Test Summary: 31159 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23524

  14. Jan Helke voted on patch set 6 V +1 CR +1 05/16/18, 08:27

  15. Anja Leichsenring voted on patch set 6 V +1 CR +1 05/16/18, 09:32

  16. Christian Kuhn voted on patch set 6 V +2 CR +2 05/16/18, 09:37

  17. Christian Kuhn merged patch set 7 05/16/18, 09:37

  18. Oliver Hader commented on patch set 7 05/18/18, 09:49

    Post -1: Filelist module currently shows only 1 file per page