5697[BUGFIX] Replace debug with call to deprecationLog
Commit message
Review
-
Code review CR +2
- Tolleiv Nietsch +2
- Oliver Hader +2
- Oliver Klee +1
-
Verified V +2
- Tolleiv Nietsch +2
- Oliver Hader +2
Issues 1
Files 1
Review log 16
-
Tolleiv Nietsch commented on patch set 1 10/19/11, 19:43
Uhm well I applied it to the 4.4 so it should - can recheck later. -
Tolleiv Nietsch commented on patch set 1 10/19/11, 19:43
Ah now I get you - ideally the request would fully drop the debug/deprecationLog command since we're in 4.4 where this is not relevant - right? -
Tolleiv Nietsch uploaded patch set 2 10/19/11, 19:43
-
Tolleiv Nietsch uploaded patch set 3 10/19/11, 19:43
-
Tolleiv Nietsch uploaded patch set 4 10/19/11, 19:43
-
Tolleiv Nietsch uploaded patch set 5 10/19/11, 19:43
-
Tolleiv Nietsch commented on patch set 5 10/19/11, 19:43
Don't ask why this has so many patches - seems that I'm not too concentrated today :( - Cheers. -
Oliver Klee commented on patch set 5 10/19/11, 19:43
Looks good to me, but someone else must approve -
Oliver Klee commented on patch set 6 10/19/11, 19:43
Looks good to me, but someone else must approve -
Oliver Hader uploaded patch set 6 10/19/11, 19:43
-
Oliver Hader commented on patch set 6 V 0 10/19/11, 19:43
by team member; Looks good to me, approved -
Oliver Hader commented on patch set 6 10/19/11, 19:43
I reintroduced the deprecation log thingy... I did not get why we should not use it here... At least it's wrong and extension authors should use the correct way - thus we write it to the deprecation log since this way is deprecated... -
Xavier Perseguers commented on patch set 1 10/19/11, 19:43
Yes, sorry for not having been clear enough -
Xavier Perseguers commented on patch set 1 10/19/11, 19:43
I would prefer that you didn't submit this Seems like it does not apply to 4.4, does it? -
Tolleiv Nietsch commented on patch set 6 V 0 10/19/11, 19:43
by team member; Looks good to me, approved Thx cool - not even sure what's keeping us back to cherry-pick it ;) -
Tolleiv Nietsch merged patch set 6 10/19/11, 19:43