Review TYPO3_4-4 Merged

5697[BUGFIX] Replace debug with call to deprecationLog

Tolleiv Nietsch CR +2 V +2 Easy +2 −2 updated 06/03/13, 20:49

Commit message

Commit cf83434449237114ae092659e17f8f2935f815b6 wrongly introduced
a debug() statement instead of a call to the deprecationLog()
method.

Review

  • Code review CR +2
    • Tolleiv Nietsch +2
    • Oliver Hader +2
    • Oliver Klee +1
  • Verified V +2
    • Tolleiv Nietsch +2
    • Oliver Hader +2

Issues 1

Files 1

Review log 16

  1. Tolleiv Nietsch commented on patch set 1 10/19/11, 19:43

    Uhm well I applied it to the 4.4 so it should - can recheck later.
  2. Tolleiv Nietsch commented on patch set 1 10/19/11, 19:43

    Ah now I get you - ideally the request would fully drop the debug/deprecationLog command since we're in 4.4 where this is not relevant - right?
  3. Tolleiv Nietsch uploaded patch set 2 10/19/11, 19:43

  4. Tolleiv Nietsch uploaded patch set 3 10/19/11, 19:43

  5. Tolleiv Nietsch uploaded patch set 4 10/19/11, 19:43

  6. Tolleiv Nietsch uploaded patch set 5 10/19/11, 19:43

  7. Tolleiv Nietsch commented on patch set 5 10/19/11, 19:43

    Don't ask why this has so many patches - seems that I'm not too concentrated today :( - Cheers.
  8. Oliver Klee commented on patch set 5 10/19/11, 19:43

    Looks good to me, but someone else must approve
  9. Oliver Klee commented on patch set 6 10/19/11, 19:43

    Looks good to me, but someone else must approve
  10. Oliver Hader uploaded patch set 6 10/19/11, 19:43

  11. Oliver Hader commented on patch set 6 V 0 10/19/11, 19:43

    by team member; Looks good to me, approved
  12. Oliver Hader commented on patch set 6 10/19/11, 19:43

    I reintroduced the deprecation log thingy... I did not get why we should not use it here... At least it's wrong and extension authors should use the correct way - thus we write it to the deprecation log since this way is deprecated...
  13. Xavier Perseguers commented on patch set 1 10/19/11, 19:43

    Yes, sorry for not having been clear enough
  14. Xavier Perseguers commented on patch set 1 10/19/11, 19:43

    I would prefer that you didn't submit this Seems like it does not apply to 4.4, does it?
  15. Tolleiv Nietsch commented on patch set 6 V 0 10/19/11, 19:43

    by team member; Looks good to me, approved Thx cool - not even sure what's keeping us back to cherry-pick it ;)
  16. Tolleiv Nietsch merged patch set 6 10/19/11, 19:43