Review TYPO3_7-6 Merged

56972[BUGFIX] PHP 7 Reflection error for default value

Wouter Wolters CR +2 V +2 Easy +1 −2 updated 06/01/18, 15:00

Commit message

In PHP 7, under some circumstances the exception is not caught
as expected.
Therefore we use a check (as already done in ReflectionService.php).

Review

  • Code review CR +2
    • Jan Helke +2
    • Anja Leichsenring +1
    • Daniel Siepmann +1
    • Mona Muzaffar +1
  • Verified V +2
    • Jan Helke +2
    • Anja Leichsenring +1
    • Daniel Siepmann +1
    • Mona Muzaffar +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1721

  1. Wouter Wolters commented on patch set 1 05/16/18, 07:02

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 05/16/18, 07:09 Completed build in 07m 25s on Wed, 16 May, 09:09 AM Test Summary: 49207 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1467

  3. Mathias Brodala voted on patch set 1 CR +1 05/16/18, 08:38

  4. Oliver Klee updated the commit message in patch set 2 05/16/18, 12:48

  5. Andreas Kienast voted on patch set 2 CR +1 05/16/18, 12:53

  6. TYPO3com voted on patch set 2 V +1 05/16/18, 12:56 Completed build in 07m 21s on Wed, 16 May, 02:56 PM Test Summary: 49207 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1468

  7. Mathias Brodala voted on patch set 2 CR +1 05/16/18, 15:06

  8. Christian Kuhn commented on patch set 2 05/16/18, 16:14

    is v8 affected, too?
  9. Daniel Siepmann commented on patch set 2 V -1 05/16/18, 16:39

    I'm still testing for the need of TYPO3 CMS 8 and master
  10. Daniel Siepmann voted on patch set 2 V +1 05/16/18, 17:23

  11. Mathias Brodala updated the commit message in patch set 3 05/30/18, 14:56

  12. Mathias Brodala updated the commit message in patch set 4 05/30/18, 14:57

  13. Mathias Brodala commented on patch set 4 05/30/18, 14:57

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit efa5fdb400d3e9cd3e5b19cccd281358c46533db
  14. Mathias Brodala commented on patch set 4 05/30/18, 14:57

    The issue was also seen on PHP 7.0 with TYPO3v8, thus adding it there too.
  15. TYPO3com voted on patch set 3 V +1 05/30/18, 15:05 Completed build in 08m 20s on Wed, 30 May, 05:05 PM Test Summary: 49207 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1480

  16. TYPO3com voted on patch set 4 V +1 05/30/18, 15:10 Completed build in 12m 56s on Wed, 30 May, 05:10 PM Test Summary: 49207 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1481

  17. Daniel Siepmann voted on patch set 4 V +1 CR +1 05/30/18, 17:45

  18. Anja Leichsenring voted on patch set 4 V +1 CR +1 06/01/18, 12:50

  19. Mona Muzaffar voted on patch set 4 V +1 CR +1 06/01/18, 12:59

  20. Jan Helke voted on patch set 4 V +2 CR +2 06/01/18, 14:55

  21. Jan Helke merged patch set 5 06/01/18, 15:00