Review main Merged

56974[TASK] Add functional tests for QueryGeneratorTest

Alexander Schnitzler CR +2 V +2 Hard +289 −1 updated 05/16/18, 16:27

Commit message

Review

  • Code review CR +2
    • Jan Helke +2
    • Christian Kuhn +1
  • Verified V +2
    • Jan Helke +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 916

  1. Alexander Schnitzler uploaded patch set 1 05/16/18, 10:22

  2. TYPO3com voted on patch set 1 V +1 05/16/18, 10:29 Completed build in 07m 21s on Wed, 16 May, 12:29 PM Test Summary: 31185 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23529

  3. Alexander Schnitzler uploaded patch set 2 05/16/18, 10:45

  4. TYPO3com voted on patch set 2 V +1 05/16/18, 10:52 Completed build in 07m 32s on Wed, 16 May, 12:52 PM Test Summary: 31187 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23531

  5. Alexander Schnitzler uploaded patch set 3 05/16/18, 11:13

  6. Alexander Schnitzler uploaded patch set 4 05/16/18, 11:19

  7. TYPO3com voted on patch set 3 V -1 05/16/18, 11:22 Completed build in 08m 54s on Wed, 16 May, 01:22 PM Test Summary: 1 of 31440 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23533

  8. TYPO3com voted on patch set 4 V -1 05/16/18, 11:27 Completed build in 07m 32s on Wed, 16 May, 01:27 PM Test Summary: 1 of 31440 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23535

  9. TYPO3com commented on patch set 4 05/16/18, 11:38 Completed build in 26m 16s on Wed, 16 May, 01:38 PM Test Summary: 1 of 31440 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23535

  10. Alexander Schnitzler uploaded patch set 5 05/16/18, 11:51

  11. TYPO3com voted on patch set 5 V -1 05/16/18, 11:58 Completed build in 07m 04s on Wed, 16 May, 01:58 PM Test Summary: 31184 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23540

  12. Alexander Schnitzler uploaded patch set 6 05/16/18, 12:12

  13. TYPO3com voted on patch set 6 V +1 05/16/18, 12:20 Completed build in 08m 21s on Wed, 16 May, 02:20 PM Test Summary: 31189 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23541

  14. Christian Kuhn commented on patch set 6 V +1 CR +1 05/16/18, 16:21

    QueryGenerator.php:1585

    note: is ok, needed for non-mysql to return a stable sorted result list.
  15. Jan Helke voted on patch set 6 V +2 CR +2 05/16/18, 16:27

  16. Jan Helke merged patch set 7 05/16/18, 16:27