56975[CLEANUP] Restructure code of extbase class Typo3DbBackend
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 78
-
Bernhard Kraft uploaded patch set 1 05/16/18, 10:27
-
TYPO3com voted on patch set 1 V -1 05/16/18, 10:27 Completed build in 06s on Wed, 16 May, 12:27 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23530
-
Benni Mack commented on patch set 1 08/10/18, 17:28
Hi Bernhard, this code will probably not be necessary with the Context API, as this has been refactored already. I'd opt for abandon this patch. What do you think? -
Bernhard Kraft commented on patch set 1 08/11/18, 01:56
I haven't taken a look at the new situation right now but will do soon. The basic problem was that it is not possible to retrieve a record exactly by UID circumventing workspace AND/OR translation overlays. This would be necessary for BE modules and alike. -
Anja Leichsenring commented on patch set 1 09/07/18, 09:14
I just looked at the code and tried to adapt the patch to the current codebase. It changed too much for a somehow clean rebase, sorry. I support the abandon proposal by Benni and suggest to start fresh from current codebase. -
Anja Leichsenring commented on patch set 1 09/07/18, 09:20
> Patch Set 1: > > I just looked at the code and tried to adapt the patch to the current codebase. It changed too much for a somehow clean rebase, sorry. I support the abandon proposal by Benni and suggest to start fresh from current codebase. By the way, the method you try to refactor has unit tests attached. You should probably have a look at those, and add / adjust to your wanted behavior. -
Susi Moog commented on patch set 1 09/07/18, 09:23
This patch is potentially not needed anymore, Tymek wanted to take a look. -
Tymoteusz Motylewski abandoned the change 09/07/18, 19:06
Im abandoning the patch as after introducing contex api the code is better already. However @bernhard, i would be very interesting in hearing your usecase where you need different logic for fetching records as Im working on this area right now. Please contact me on slack