Review main Merged Breaking

56976[!!!][TASK] Make all enumerations final

Mathias Brodala CR +2 V +2 Hard +117 −147 updated 06/01/18, 12:57

Commit message

Code which uses enumerations expects a known set of values, adding
more values by extending these classes leads to undefined behavior.

Since it is now impossible to create a mock of an enumeration also
drop a few Enumeration tests and stick to testing of the public API.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Anja Leichsenring +1
    • Jan Helke +1
    • Mona Muzaffar +1
    • Jörg Bösche +1
  • Verified V +2
    • Andreas Kienast +2
    • Anja Leichsenring +1
    • Jan Helke +1
    • Mona Muzaffar +1
    • TYPO3com +1 CI

Issues 1

Files 16

Review log 2229

Show 24 earlier messages
  1. Mathias Brodala uploaded patch set 1 05/16/18, 10:59

  2. TYPO3com voted on patch set 1 V -1 05/16/18, 11:07 Completed build in 07m 34s on Wed, 16 May, 01:07 PM Test Summary: 2935 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23532

  3. Mathias Brodala uploaded patch set 2 05/16/18, 11:15

  4. TYPO3com voted on patch set 2 V -1 05/16/18, 11:24 Completed build in 09m 41s on Wed, 16 May, 01:24 PM Test Summary: 2935 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23534

  1. Mathias Brodala uploaded patch set 3 05/16/18, 14:46

  2. Mathias Brodala uploaded patch set 4 05/16/18, 14:47

  3. TYPO3com voted on patch set 3 V -1 05/16/18, 14:54 Completed build in 08m 09s on Wed, 16 May, 04:55 PM Test Summary: 42 of 31391 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23547

  4. TYPO3com voted on patch set 4 V -1 05/16/18, 14:55 Completed build in 07m 52s on Wed, 16 May, 04:55 PM Test Summary: 30 of 31391 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23548

  5. Mathias Brodala uploaded patch set 5 05/16/18, 14:59

  6. TYPO3com voted on patch set 5 V +1 05/16/18, 15:07 Completed build in 07m 48s on Wed, 16 May, 05:07 PM Test Summary: 31126 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23549

  7. Mathias Brodala updated the commit message in patch set 6 05/17/18, 09:40

  8. TYPO3com voted on patch set 6 V +1 05/17/18, 09:47 Completed build in 06m 49s on Thu, 17 May, 11:47 AM Test Summary: 31204 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23607

  9. Susi Moog voted on patch set 6 CR +1 05/17/18, 11:54

  10. Susi Moog voted on patch set 6 V +1 05/18/18, 10:32

  11. Frank Nägler commented on patch set 6 CR -1 05/18/18, 13:25

    Did we really need to backport this patch to v8? This change will fatal if any installed extension extends one of the this classes.
  12. Mathias Brodala commented on patch set 6 05/18/18, 13:41

    > Did we really need to backport this patch to v8? > This change will fatal if any installed extension extends one of > the this classes. Yes, this might not be the best experience but by the nature of this change this should not happen at all. I'm not adamant about the v8 backport so I don't mind if there is none.
  13. Frank Nägler commented on patch set 6 05/18/18, 13:43

    > > Did we really need to backport this patch to v8? > > This change will fatal if any installed extension extends one of > > the this classes. > > Yes, this might not be the best experience but by the nature of > this change this should not happen at all. > > I'm not adamant about the v8 backport so I don't mind if there is > none. I think the benefit is not worth the risk (for v8) for master I am fine.
  14. Mathias Brodala commented on patch set 6 05/18/18, 13:44

    > I think the benefit is not worth the risk (for v8) for master I am > fine. OK, I'll amend. Do you think this should be marked as breaking and get an RST?
  15. Frank Nägler commented on patch set 6 05/18/18, 13:49

    rst? why not, it does not hurt...
  16. Mathias Brodala uploaded patch set 7 05/18/18, 14:01

  17. TYPO3com voted on patch set 7 V +1 05/18/18, 14:10 Completed build in 08m 28s on Fri, 18 May, 04:10 PM Test Summary: 31214 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23662

  18. Jörg Bösche voted on patch set 7 CR +1 05/30/18, 06:19

  19. Anja Leichsenring voted on patch set 7 V +1 CR +1 06/01/18, 12:49

  20. Mona Muzaffar voted on patch set 7 V +1 CR +1 06/01/18, 12:50

  21. Andreas Kienast commented on patch set 7 CR -1 06/01/18, 12:52

    on it
  22. Jan Helke voted on patch set 7 V +1 06/01/18, 12:53

  23. Jan Helke voted on patch set 7 CR +1 06/01/18, 12:54

  24. Andreas Kienast voted on patch set 7 V +2 CR +2 06/01/18, 12:57

  25. Andreas Kienast merged patch set 8 06/01/18, 12:57