56979[TASK] Remove saltedpasswords FE.enabled
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Anja Leichsenring +1
-
Verified V +2
- Markus Klein +2
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 2
Files 18
- typo3/sysext/core/Classes/Service/AbstractService.php+1 −2
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-85027-SaltedPasswordsRelatedMethodsAndClasses.rstnew+34 −0
- typo3/sysext/core/Documentation/Changelog/master/Important-85022-SaltedpasswordsBulkUpdateTaskRemoved.rstdeleted+0 −49
- typo3/sysext/core/Documentation/Changelog/master/Important-85026-SaltedpasswordsChanges.rst2new+85 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallStaticMatcher.php+7 −0
- typo3/sysext/saltedpasswords/Classes/Evaluation/Evaluator.php+13 −26
- typo3/sysext/saltedpasswords/Classes/Utility/ExtensionManagerConfigurationUtility.php+53 −59
- typo3/sysext/saltedpasswords/Classes/Utility/SaltedPasswordsUtility.php2+9 −17
- typo3/sysext/saltedpasswords/Classes/SaltedPasswordService.php+5 −16
- typo3/sysext/saltedpasswords/Configuration/TCA/Overrides/fe_users.php3+9 −11
- typo3/sysext/saltedpasswords/Documentation/Configuration/Index.rst+2 −11
- typo3/sysext/saltedpasswords/Documentation/DevelopersGuide/Index.rst+7 −18
- typo3/sysext/saltedpasswords/Documentation/Installation/Index.rst+0 −3
- typo3/sysext/saltedpasswords/Resources/Private/Language/locallang.xlf+1 −4
- typo3/sysext/saltedpasswords/Resources/Private/Language/locallang_em.xlf+2 −5
- typo3/sysext/saltedpasswords/Tests/Unit/Evaluation/EvaluatorTest.php+8 −26
- typo3/sysext/saltedpasswords/Tests/Unit/Salt/SaltFactoryTest.php+3 −3
- typo3/sysext/saltedpasswords/ext_conf_template.txt+0 −3
Review log 1722
-
Christian Kuhn uploaded patch set 1 05/16/18, 15:30
-
Christian Kuhn voted on patch set 1 CR -1 05/16/18, 15:35
-
TYPO3com voted on patch set 1 V -1 05/16/18, 15:37 Completed build in 07m 35s on Wed, 16 May, 05:37 PM Test Summary: 1 of 31400 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23553
-
Christian Kuhn uploaded patch set 2 05/16/18, 15:51
-
TYPO3com voted on patch set 2 V +1 05/16/18, 16:00 Completed build in 09m 37s on Wed, 16 May, 06:00 PM Test Summary: 31153 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23554
-
Markus Klein commented on patch set 2 05/16/18, 16:26
fe_users.php:10::class -
Markus Klein commented on patch set 3 05/16/18, 16:26
Published edit on patch set 2. -
Markus Klein uploaded patch set 4 05/16/18, 16:29
-
Markus Klein voted on patch set 4 V +1 CR +1 05/16/18, 16:31
-
Christian Kuhn commented on patch set 2 05/16/18, 16:31
SaltedPasswordsUtility.php:128Replywilco.fe_users.php:10Replyi tend to keep that for the time being. i think the two TCA/Overrides files can be removed soon, anyway, so let's do that with another patch. -
Christian Kuhn commented on patch set 4 05/16/18, 16:32
fe_users.php:10Replyah, you pushed a new version already. even better. thx! -
TYPO3com voted on patch set 3 V +1 05/16/18, 16:37 Completed build in 10m 27s on Wed, 16 May, 06:37 PM Test Summary: 31153 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23562
-
TYPO3com voted on patch set 4 V +1 05/16/18, 16:39 Completed build in 09m 29s on Wed, 16 May, 06:39 PM Test Summary: 31183 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23564
-
Tymoteusz Motylewski voted on patch set 4 CR +1 05/16/18, 20:12
-
Alexander Stehlik voted on patch set 4 CR +1 05/16/18, 21:51
-
Andreas Kienast commented on patch set 4 CR -1 05/17/18, 07:24
Important-85026-SaltedpasswordsChanges.rst:7Should be 85026, I guess -
Christian Kuhn commented on patch set 4 05/17/18, 08:03
Important-85026-SaltedpasswordsChanges.rst:7Reply Unresolvedyeah. thx. wanted to have the epic id in there. -
Christian Kuhn uploaded patch set 5 05/17/18, 08:06
-
Anja Leichsenring voted on patch set 5 V +1 CR +1 05/17/18, 08:13
-
TYPO3com voted on patch set 5 V +1 05/17/18, 08:13 Completed build in 07m 20s on Thu, 17 May, 10:13 AM Test Summary: 31231 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23593
-
Markus Klein voted on patch set 5 V +2 CR +2 05/17/18, 08:46
-
Markus Klein merged patch set 6 05/17/18, 08:47
SaltedPasswordsUtility.php:128