Review main Merged

56979[TASK] Remove saltedpasswords FE.enabled

Christian Kuhn CR +2 V +2 Hard +239 −253 updated 05/17/18, 08:47

Commit message

Manually configuring clear-text password storage in TYPO3 for
frontend users by explicitly setting the ext:saltedpasswords
extension configuration "FE.enabled = 0" has been a bad idea
for a very long time already. The feature has been dropped
for backend users in core v6.2 and is now finally dropped
for frontend users with this patch, too.
No third party service must rely on clear-text password storing
in 2018 anymore, the TYPO3 authentication services provide
an API to process credentials upon user login for authentication
and authorisation purposes.

Review

  • Code review CR +2
    • Markus Klein +2
    • Anja Leichsenring +1
  • Verified V +2
    • Markus Klein +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 2

Files 18

Review log 1722

  1. Christian Kuhn uploaded patch set 1 05/16/18, 15:30

  2. Christian Kuhn voted on patch set 1 CR -1 05/16/18, 15:35

  3. TYPO3com voted on patch set 1 V -1 05/16/18, 15:37 Completed build in 07m 35s on Wed, 16 May, 05:37 PM Test Summary: 1 of 31400 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23553

  4. Christian Kuhn uploaded patch set 2 05/16/18, 15:51

  5. TYPO3com voted on patch set 2 V +1 05/16/18, 16:00 Completed build in 09m 37s on Wed, 16 May, 06:00 PM Test Summary: 31153 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23554

  6. Markus Klein commented on patch set 2 05/16/18, 16:26

    SaltedPasswordsUtility.php:128

    returns

    fe_users.php:10

    ::class
  7. Markus Klein commented on patch set 3 05/16/18, 16:26

    Published edit on patch set 2.
  8. Markus Klein uploaded patch set 4 05/16/18, 16:29

  9. Markus Klein voted on patch set 4 V +1 CR +1 05/16/18, 16:31

  10. Christian Kuhn commented on patch set 2 05/16/18, 16:31

    SaltedPasswordsUtility.php:128 Reply

    wilco.

    fe_users.php:10 Reply

    i tend to keep that for the time being. i think the two TCA/Overrides files can be removed soon, anyway, so let's do that with another patch.
  11. Christian Kuhn commented on patch set 4 05/16/18, 16:32

    fe_users.php:10 Reply

    ah, you pushed a new version already. even better. thx!
  12. TYPO3com voted on patch set 3 V +1 05/16/18, 16:37 Completed build in 10m 27s on Wed, 16 May, 06:37 PM Test Summary: 31153 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23562

  13. TYPO3com voted on patch set 4 V +1 05/16/18, 16:39 Completed build in 09m 29s on Wed, 16 May, 06:39 PM Test Summary: 31183 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23564

  14. Tymoteusz Motylewski voted on patch set 4 CR +1 05/16/18, 20:12

  15. Alexander Stehlik voted on patch set 4 CR +1 05/16/18, 21:51

  16. Andreas Kienast commented on patch set 4 CR -1 05/17/18, 07:24

    Important-85026-SaltedpasswordsChanges.rst:7

    Should be 85026, I guess
  17. Christian Kuhn commented on patch set 4 05/17/18, 08:03

    Important-85026-SaltedpasswordsChanges.rst:7 Reply Unresolved

    yeah. thx. wanted to have the epic id in there.
  18. Christian Kuhn uploaded patch set 5 05/17/18, 08:06

  19. Anja Leichsenring voted on patch set 5 V +1 CR +1 05/17/18, 08:13

  20. TYPO3com voted on patch set 5 V +1 05/17/18, 08:13 Completed build in 07m 20s on Thu, 17 May, 10:13 AM Test Summary: 31231 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23593

  21. Markus Klein voted on patch set 5 V +2 CR +2 05/17/18, 08:46

  22. Markus Klein merged patch set 6 05/17/18, 08:47