56981[TASK] Improved form editor hints and validations
Commit message
Review
-
Code review CR +2
- Ralf Zimmermann +2
- Björn Jacob +1
- Susi Moog +1
-
Verified V +2
- Ralf Zimmermann +2
- Björn Jacob +1
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 9
- Build/Resources/Public/Sass/form.scss+40 −0
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/FinishersEditor.html+7 −3
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/RequiredValidatorEditor.html+1 −1
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/TextareaEditor.html+1 −1
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/TextEditor.html+1 −1
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/Typo3WinBrowserEditor.html+1 −1
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/ValidationErrorMessageEditor.html+1 −1
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/ValidatorsEditor.html+7 −3
- typo3/sysext/form/Resources/Public/Css/form.css+1 −1
Review log 1218
-
Daniela Pohl uploaded patch set 1 05/16/18, 16:55
-
TYPO3com voted on patch set 1 V -1 05/16/18, 16:55 Completed build in 05s on Wed, 16 May, 06:55 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23567
-
Susi Moog commented on patch set 2 05/16/18, 17:18
Published edit on patch set 1. -
TYPO3com voted on patch set 2 V +1 05/16/18, 17:27 Completed build in 09m 00s on Wed, 16 May, 07:27 PM Test Summary: 31183 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23573
-
Björn Jacob commented on patch set 2 V -1 05/17/18, 08:26
Finishers: * margin between field and hint looks good to me Validators * added to a input field a "Number range" validator * margon looks good to me/ similiar to finishers Special form elements * added form element of type "Content element" * margin is too big between field and hint ToDo * add a form element of type "textarea" * mark field "Required field" * the hint for "Custom error message" is not styled * same is valid for "Single select" element -> "Inactive option" * furthermore, margin is not correct when adding a validator (e.g. "Number" and checking "Custom error message") * hints for required textareas are not styled correctly -
Daniela Pohl uploaded patch set 3 05/17/18, 14:22
-
TYPO3com voted on patch set 3 V -1 05/17/18, 14:22 Completed build in 07s on Thu, 17 May, 04:22 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23627
-
Daniela Pohl uploaded patch set 4 05/17/18, 14:35
-
TYPO3com voted on patch set 4 V -1 05/17/18, 14:43 Completed build in 08m 03s on Thu, 17 May, 04:43 PM Test Summary: 31231 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23628
-
Björn Jacob updated the commit message in patch set 5 05/17/18, 14:45
-
Björn Jacob commented on patch set 5 V +1 CR +1 05/17/18, 14:50
Nice. All done! -
TYPO3com voted on patch set 5 V -1 05/17/18, 14:52 Completed build in 06m 54s on Thu, 17 May, 04:52 PM Test Summary: 31231 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23629
-
Björn Jacob commented on patch set 6 05/17/18, 14:56
Published edit on patch set 5. -
TYPO3com voted on patch set 6 V +1 05/17/18, 15:04 Completed build in 08m 25s on Thu, 17 May, 05:04 PM Test Summary: 31231 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23630
-
Björn Jacob voted on patch set 6 V +1 CR +1 05/17/18, 15:05
-
Susi Moog voted on patch set 6 V +1 CR +1 05/17/18, 16:28
-
Ralf Zimmermann voted on patch set 6 V +2 CR +2 05/17/18, 16:35
-
Ralf Zimmermann merged patch set 7 05/17/18, 16:36