Review main Merged

56985[BUGFIX] Prevent endless loop in recycler folder detection

Alexander Stehlik CR +2 V +2 Easy +42 −2 updated 05/18/18, 10:28

Commit message

Compare folder identifiers instead of folder objects because
objects pointing to the same folder might still be different
object instances.

Review

  • Code review CR +2
    • Markus Klein +2
    • Björn Jacob +1
    • Frans Saris +1
    • Susi Moog +1
  • Verified V +2
    • Markus Klein +2
    • Björn Jacob +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 911

  1. Alexander Stehlik uploaded patch set 1 05/16/18, 21:17

  2. TYPO3com voted on patch set 1 V +1 05/16/18, 21:24 Completed build in 07m 15s on Wed, 16 May, 11:24 PM Test Summary: 31191 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23583

  3. Michael Oehlhof voted on patch set 1 CR +1 05/16/18, 22:30

  4. Susi Moog commented on patch set 2 05/18/18, 09:45

    Published edit on patch set 1.
  5. TYPO3com voted on patch set 2 V +1 05/18/18, 09:54 Completed build in 08m 37s on Fri, 18 May, 11:54 AM Test Summary: 31235 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23643

  6. Frans Saris voted on patch set 2 CR +1 05/18/18, 10:17

  7. Susi Moog voted on patch set 2 V +1 CR +1 05/18/18, 10:20

  8. Markus Klein voted on patch set 2 V +2 CR +2 05/18/18, 10:25

  9. Markus Klein merged patch set 3 05/18/18, 10:26

  10. Markus Klein commented on patch set 3 05/18/18, 10:26

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit cfc3df75bacfd6a51d2fd0f1e22c92f611cfb809
  11. Björn Jacob voted on patch set 3 V +1 CR +1 05/18/18, 10:28