Review TYPO3_8-7 Merged

56989[BUGFIX] Set opt-in for override checkbox in TCA input elements

Markus Klein CR +2 V +2 Easy +0 −15 updated 05/17/18, 12:48

Commit message

When useOrOverridePlaceholder mode is used for TCA input type,
use opt-in for the checkbox when placeholder is empty.

In some cases, the placeholder can be empty. Especially when the
placeholder uses data from another field. When information is added
to the corresponding field, the input field does not take this in account
because the override checkbox is set by default.

This can lead to problems for title and alternative fields in the
sys_file_metadata table. When adding a file reference and setting the
title or alternative field afterwards in the original file, the reference
is still using the empty override from file reference.

Review

  • Code review CR +2
    • Markus Klein +2
  • Verified V +2
    • Markus Klein +2
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 34

  1. Markus Klein commented on patch set 1 05/17/18, 08:17

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 05/17/18, 08:32 Completed build in 14m 45s on Thu, 17 May, 10:32 AM Test Summary: 58280 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2464

  3. Markus Klein voted on patch set 1 V +2 CR +2 05/17/18, 12:48

  4. Markus Klein merged patch set 2 05/17/18, 12:48