Review main Merged

56999[TASK] Clarify changelog file placement

TYPO3com CR +2 V +2 Normal +30 −25 updated 05/30/18, 07:06

Commit message

Review

  • Code review CR +2
    • Tymoteusz Motylewski +2
    • Christian Kuhn +1
  • Verified V +2
    • Tymoteusz Motylewski +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1318

  1. TYPO3com uploaded patch set 1 05/18/18, 09:08

  2. Christian Kuhn commented on patch set 1 05/18/18, 09:12

    Howto.rst:80

    and 8.7.x ...
  3. TYPO3com voted on patch set 1 V +1 05/18/18, 09:15 Completed build in 06m 52s on Fri, 18 May, 11:15 AM Test Summary: 31231 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23640

  4. Riccardo De Contardi commented on patch set 2 05/27/18, 16:06

    Published edit on patch set 1.
  5. Riccardo De Contardi commented on patch set 2 05/27/18, 16:07

    @Christian Kuhn take a look if it sounds good to you. TX.
  6. TYPO3com voted on patch set 2 V +1 05/27/18, 16:15 Completed build in 08m 39s on Sun, 27 May, 06:15 PM Test Summary: 31095 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23797

  7. Georg Ringer voted on patch set 2 V +1 CR +1 05/28/18, 06:45

  8. Jörg Bösche voted on patch set 2 V +1 CR +1 05/29/18, 06:02

  9. Markus Klein commented on patch set 2 05/29/18, 07:33

    Howto.rst:46

    isn't that rather breaking??

    Howto.rst:81

    have

    Howto.rst:84

    lets shorten the line
  10. Tymoteusz Motylewski commented on patch set 3 05/29/18, 21:15

    Published edit on patch set 2.
  11. TYPO3com voted on patch set 3 V +1 05/29/18, 21:22 Completed build in 07m 04s on Tue, 29 May, 11:22 PM Test Summary: 31122 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23882

  12. Christian Kuhn voted on patch set 3 CR -1 05/29/18, 21:46

  13. Christian Kuhn uploaded patch set 4 05/29/18, 21:52

  14. Christian Kuhn voted on patch set 4 V +1 CR +1 05/29/18, 21:53

  15. TYPO3com voted on patch set 4 V +1 05/29/18, 21:59 Completed build in 07m 07s on Tue, 29 May, 11:59 PM Test Summary: 31122 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23884

  16. Tymoteusz Motylewski voted on patch set 4 V +2 CR +2 05/29/18, 22:03

  17. Tymoteusz Motylewski merged patch set 5 05/29/18, 22:03

  18. Mathias Brodala commented on patch set 2 05/30/18, 07:06

    Howto.rst:46 Reply

    We had that case quite a few times already and each time we only added an Important RST since the change itself is not breaking but you won't get 100% functionality/fixes unless you copy the change.