Review main Merged

57003[BUGFIX] Use proper fallback value of files per page in file list module

Oliver Hader CR +2 V +2 Easy +1 −1 updated 05/18/18, 10:42

Commit message

In case TSconfig options.file_list.filesPerPage is not defined the
resulting value falls back to 1 - however this should be the same as
defined in FileList::$iLimit, which is 40 per default.

Review

  • Code review CR +2
    • Susi Moog +2
    • Björn Jacob +1
    • Ralf Zimmermann +1
  • Verified V +2
    • Susi Moog +2
    • Björn Jacob +1
    • Ralf Zimmermann +1

Issues 1

Files 1

Review log 78

  1. Oliver Hader uploaded patch set 1 05/18/18, 10:36

  2. Susi Moog voted on patch set 1 V +1 CR +1 05/18/18, 10:37

  3. Ralf Zimmermann voted on patch set 1 CR +1 05/18/18, 10:40

  4. Ralf Zimmermann voted on patch set 1 V +1 05/18/18, 10:41

  5. Björn Jacob voted on patch set 1 V +1 CR +1 05/18/18, 10:41

  6. Susi Moog voted on patch set 1 V +2 CR +2 05/18/18, 10:42

  7. Susi Moog merged patch set 2 05/18/18, 10:42

  8. TYPO3com voted on patch set 1 V +1 05/18/18, 10:42 Completed build in 06m 35s on Fri, 18 May, 12:42 PM Test Summary: 31241 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23649