Review main Merged

57007[TASK] Optimize the tree of the form editor

Benjamin Burse CR +2 V +2 Easy +22 −3 updated 05/24/18, 07:18

Commit message

- remove linebreak in root node
  -> instead use text-overflow: ellipsis
- fix indentation of tree elements
  -> move triangles indicating subtrees to the left
- changed tooltip message to only show "id = <element-id>"

Review

  • Code review CR +2
    • Ralf Zimmermann +2
    • Susi Moog +1
  • Verified V +2
    • Ralf Zimmermann +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1113

  1. Benjamin Burse uploaded patch set 1 05/18/18, 13:38

  2. TYPO3com voted on patch set 1 V -1 05/18/18, 13:38 Completed build in 05s on Fri, 18 May, 03:38 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23659

  3. Benjamin Burse uploaded patch set 2 05/18/18, 14:07

  4. Ralf Zimmermann voted on patch set 2 V +1 CR +1 05/18/18, 14:16

  5. TYPO3com voted on patch set 2 V +1 05/18/18, 14:17 Completed build in 09m 59s on Fri, 18 May, 04:17 PM Test Summary: 31213 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23664

  6. Susi Moog commented on patch set 2 V -1 05/18/18, 14:27

    error icon on top level does not work anymore.
  7. Ralf Zimmermann commented on patch set 2 V 0 CR -1 05/18/18, 14:30

    on it
  8. Benjamin Burse commented on patch set 2 05/18/18, 15:05

    > error icon on top level does not work anymore. Error icon was already broken in earlier commits - checked that with current master.
  9. Ralf Zimmermann commented on patch set 2 V +1 CR +1 05/18/18, 15:06

    Not related to this patch. Should be done with another patchset.
  10. Susi Moog wrote 05/20/18, 19:06

    Removed Verified-1 by Susanne Moog <susanne.moog@typo3.org>
  11. Susi Moog voted on patch set 2 V +1 CR +1 05/20/18, 19:06

  12. Ralf Zimmermann voted on patch set 2 V +2 CR +2 05/24/18, 07:17

  13. Ralf Zimmermann merged patch set 3 05/24/18, 07:18