Review main Merged

57009[BUGFIX] Make ckeditor link browser not drop additional link params

Kevin Ditscheid CR +2 V +2 Easy +3 −0 updated 06/07/18, 11:28

Commit message

Fix the link browser to not drop the additional link params if
editing a link with additional link params set.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Andreas Wolf +1
  • Verified V +2
    • Frank Nägler +2
    • Andreas Wolf +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 78

  1. Kevin Ditscheid uploaded patch set 1 05/18/18, 14:22

  2. TYPO3com voted on patch set 1 V +1 05/18/18, 14:30 Completed build in 07m 46s on Fri, 18 May, 04:30 PM Test Summary: 31213 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23666

  3. Tymoteusz Motylewski commented on patch set 1 05/26/18, 21:20

    BrowseLinksController.php:172

    Is it safe to always start the string with &? Can we be sure thet it will not be the first argument?
  4. Andreas Wolf commented on patch set 1 V +1 CR +1 06/05/18, 17:46

    BrowseLinksController.php:172 Reply

    Actually, the parameter *must* start with &, otherwise it would be concatenated w/o a separator. The resulting URL would then be "t3://page?uid=30L=1", which does not work anymore.
  5. Kevin Ditscheid commented on patch set 1 06/06/18, 07:16

    BrowseLinksController.php:172 Reply

    Actually, I don't know if it could happen, that the additional parameters are the only ones in the link. Thing is, even if the user applied the & character by themself, it got dropped at this point. I am sadly not this much into it, that I can make a relyable answer to this, though I hope that another one can.
  6. Frank Nägler voted on patch set 1 V +2 CR +2 06/07/18, 11:27

  7. Frank Nägler merged patch set 2 06/07/18, 11:28

  8. Frank Nägler commented on patch set 2 06/07/18, 11:28

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 9ae88569328704db5d893f37fbbd1cc1acb60d82