57013[WIP][FEATURE] Add possibility to deny setting cookies on client side
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 12
- typo3/sysext/backend/Classes/Controller/LoginController.php+35 −1
- typo3/sysext/core/Classes/Authentication/AbstractUserAuthentication.php+30 −3
- typo3/sysext/core/Classes/Privacy/CookieHandler.phpnew+25 −0
- typo3/sysext/core/Classes/Privacy/CookiePayload.phpnew+130 −0
- typo3/sysext/core/Classes/Privacy/CookieService.php2new+143 −0
- typo3/sysext/core/Classes/Privacy/DenyHandler.phpnew+28 −0
- typo3/sysext/core/Configuration/DefaultConfiguration.php+8 −0
- typo3/sysext/core/Documentation/Changelog/master/Feature-85051-AddPossibilityToDenySettingCookiesOnClientSide.rstnew+63 −0
- typo3/sysext/rsaauth/Classes/Storage/AbstractStorage.php+29 −0
- typo3/sysext/rsaauth/Classes/Storage/SessionStorage.php+4 −1
- typo3/sysext/rsaauth/Classes/Storage/SplitStorage.php+6 −12
- typo3/sysext/workspaces/Classes/Middleware/WorkspacePreview.php+17 −1
Review log 1014
-
Oliver Hader uploaded patch set 1 05/19/18, 12:41
-
TYPO3com voted on patch set 1 V -1 05/19/18, 12:41 Completed build in 06s on Sat, 19 May, 02:41 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23677
-
Oliver Hader uploaded patch set 2 05/19/18, 12:48
-
TYPO3com voted on patch set 2 V -1 05/19/18, 12:55 Completed build in 06m 48s on Sat, 19 May, 02:55 PM Test Summary: 2 of 31460 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23678
-
Oliver Hader uploaded patch set 3 05/19/18, 13:00
-
TYPO3com voted on patch set 3 V -1 05/19/18, 13:08 Completed build in 08m 11s on Sat, 19 May, 03:08 PM Test Summary: 2 of 31460 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23679
-
Oliver Hader uploaded patch set 4 05/19/18, 13:10
-
TYPO3com voted on patch set 4 V +1 05/19/18, 13:17 Completed build in 06m 43s on Sat, 19 May, 03:17 PM Test Summary: 31213 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23680
-
Markus Klein commented on patch set 4 05/19/18, 20:05
this one is not yet ratified. ePrivacy Directive is what is national law currently. -
Markus Klein commented on patch set 4 CR -1 05/19/18, 20:06
I disagree on the change, because the current ePrivacy Directive (in the form of national laws) does not require any consent from the user for technical cookies, like session cookies. The core does not employ anything else than technical cookies hence, this is not needed IMO -
Oliver Hader commented on patch set 4 05/20/18, 07:37
Markus, it seems your comment refers only to the text in the commit message and the RST file. Ignoring the legal aspects for a moment, I think it might make sense to streamline cookie handling in TYPO3 in general - not necessarily like done in this WIP/POC, but may also with using middlewares and the possibility to intercept that information. -
Markus Klein commented on patch set 4 05/20/18, 07:50
Yep, I focused on the purpose of the patch as described in the commit message. ;-) I've nothing against streamlining the API in general. -
Nicole Hummel commented on patch set 4 CR -1 05/23/18, 13:26
CookieService.php:42IMHO we need to switch the if clauses and call direct handlers before the global ones.CookieService.php:137I suggest to add some canHandle() function here before actually call accept(). If I understand the current processing correctly, I need to register my own handler to '*' and cookieName. Otherwise I cannot be sure, if any other handler that was registered before already returned false and the whole process is skipped. -
Benni Mack abandoned the change 10/27/18, 20:10