Review main Merged

57019[BUGFIX] Prevent PHP notice in TreeController

Frank Nägler CR +2 V +2 Easy +1 −1 updated 05/22/18, 10:23

Commit message

With #81987 we have introduced code, which could cause PHP notices.
This patch changes the check to prevent such notices.

Review

  • Code review CR +2
    • Tymoteusz Motylewski +2
    • Markus Klein +1
    • Wouter Wolters +1
  • Verified V +2
    • Tymoteusz Motylewski +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 79

  1. Frank Nägler uploaded patch set 1 05/22/18, 07:22

  2. TYPO3com voted on patch set 1 V +1 05/22/18, 07:30 Completed build in 07m 30s on Tue, 22 May, 09:30 AM Test Summary: 31213 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23694

  3. Markus Klein updated the commit message in patch set 2 05/22/18, 07:33

  4. Markus Klein commented on patch set 2 05/22/18, 07:34

    hm... how could bamboo give a +1 if the releases line was missing ??
  5. TYPO3com voted on patch set 2 V +1 05/22/18, 07:41 Completed build in 07m 34s on Tue, 22 May, 09:41 AM Test Summary: 31213 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23695

  6. Markus Klein voted on patch set 2 V +1 CR +1 05/22/18, 08:00

  7. Wouter Wolters voted on patch set 2 CR +1 05/22/18, 08:46

  8. Tymoteusz Motylewski voted on patch set 2 V +2 CR +2 05/22/18, 10:17

  9. Tymoteusz Motylewski merged patch set 3 05/22/18, 10:23