5703[BUGFIX] Add possibility to use Wizards->Suggest in FlexForms
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Oliver Hader +1
-
Verified V +2
- Georg Ringer +2
- Oliver Hader +1
Files 1
Review log 15
-
Tolleiv Nietsch uploaded patch set 2 12/07/11, 08:15
-
Björn Pedersen commented on patch set 2 12/07/11, 08:15
Looks good to me, but someone else must approve -
Oliver Hader uploaded patch set 3 12/07/11, 08:15
-
Oliver Hader commented on patch set 3 12/07/11, 08:15
Verified; Looks good to me, but someone else must approve Rebasing to master V:1, R:1 V:0, R:1 from Björn Pedersen <bjoern.pedersen@frm2.tum.de> V:0, R:1 from Xavier Perseguers <xavier@typo3.org> V:1, R:1 from Georg Ringer <mail@ringerge.org> -
Xavier Perseguers commented on patch set 1 12/07/11, 08:15
I would prefer that you didn't submit thisWizards, with a single 'z'field namesexpandsfield nameFixes when dealing with bug fixesReleasesclass.t3lib_tceforms_suggest.php:66problem hereclass.t3lib_tceforms_suggest.php:67can we do it the other way around?class.t3lib_tceforms_suggest.php:141problemclass.t3lib_tceforms_suggest.php:143same hereclass.t3lib_tceforms_suggest.php:144count($row) > 0class.t3lib_tceforms_suggest.php:148count($parts) - 2 (with spaces)class.t3lib_tceforms_suggest.php:150superfluous spaceclass.t3lib_tceforms_suggest.php:154FALSEclass.t3lib_tceforms_suggest.php:163problemclass.t3lib_tceforms_suggest.php:165problem -
Xavier Perseguers commented on patch set 1 12/07/11, 08:15
(1 inline comment) -
Xavier Perseguers commented on patch set 1 12/07/11, 08:15
(3 inline comments) -
Xavier Perseguers commented on patch set 2 12/07/11, 08:15
Looks good to me, but someone else must approve -
Georg Ringer commented on patch set 1 12/07/11, 08:15
(1 inline comment)class.t3lib_tceforms_suggest.php:158add { } -
Georg Ringer commented on patch set 2 12/07/11, 08:15
Verified; Looks good to me, but someone else must approve -
Georg Ringer commented on patch set 3 V 0 12/07/11, 08:15
by team member; Looks good to me, approved -
Mr. Jenkins commented on patch set 1 12/07/11, 08:15
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2108/ : SUCCESS -
Mr. Jenkins commented on patch set 2 12/07/11, 08:15
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2111/ : SUCCESS -
Mr. Jenkins commented on patch set 3 12/07/11, 08:15
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2690/ : SUCCESS -
Georg Ringer merged patch set 3 12/07/11, 08:15