Review main Merged

5703[BUGFIX] Add possibility to use Wizards->Suggest in FlexForms

Tolleiv Nietsch CR +2 V +2 Easy +41 −6 updated 06/03/13, 20:49

Commit message

The field names generated for the suggest wizard are
not compatible with "flex" fields. This changes loads
the datastructure for the field and expands the
field name as needed.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Oliver Hader +1
  • Verified V +2
    • Georg Ringer +2
    • Oliver Hader +1

Files 1

Review log 15

  1. Tolleiv Nietsch uploaded patch set 2 12/07/11, 08:15

  2. Björn Pedersen commented on patch set 2 12/07/11, 08:15

    Looks good to me, but someone else must approve
  3. Oliver Hader uploaded patch set 3 12/07/11, 08:15

  4. Oliver Hader commented on patch set 3 12/07/11, 08:15

    Verified; Looks good to me, but someone else must approve Rebasing to master V:1, R:1 V:0, R:1 from Björn Pedersen <bjoern.pedersen@frm2.tum.de> V:0, R:1 from Xavier Perseguers <xavier@typo3.org> V:1, R:1 from Georg Ringer <mail@ringerge.org>
  5. Xavier Perseguers commented on patch set 1 12/07/11, 08:15

    I would prefer that you didn't submit this
    Wizards, with a single 'z'
    field names
    expands
    field name
    Fixes when dealing with bug fixes
    Releases

    class.t3lib_tceforms_suggest.php:66

    problem here

    class.t3lib_tceforms_suggest.php:67

    can we do it the other way around?

    class.t3lib_tceforms_suggest.php:141

    problem

    class.t3lib_tceforms_suggest.php:143

    same here

    class.t3lib_tceforms_suggest.php:144

    count($row) > 0

    class.t3lib_tceforms_suggest.php:148

    count($parts) - 2 (with spaces)

    class.t3lib_tceforms_suggest.php:150

    superfluous space

    class.t3lib_tceforms_suggest.php:154

    FALSE

    class.t3lib_tceforms_suggest.php:163

    problem

    class.t3lib_tceforms_suggest.php:165

    problem
  6. Xavier Perseguers commented on patch set 1 12/07/11, 08:15

    (1 inline comment)
  7. Xavier Perseguers commented on patch set 1 12/07/11, 08:15

    (3 inline comments)
  8. Xavier Perseguers commented on patch set 2 12/07/11, 08:15

    Looks good to me, but someone else must approve
  9. Georg Ringer commented on patch set 1 12/07/11, 08:15

    (1 inline comment)

    class.t3lib_tceforms_suggest.php:158

    add { }
  10. Georg Ringer commented on patch set 2 12/07/11, 08:15

    Verified; Looks good to me, but someone else must approve
  11. Georg Ringer commented on patch set 3 V 0 12/07/11, 08:15

    by team member; Looks good to me, approved
  12. Mr. Jenkins commented on patch set 1 12/07/11, 08:15

  13. Mr. Jenkins commented on patch set 2 12/07/11, 08:15

  14. Mr. Jenkins commented on patch set 3 12/07/11, 08:15

  15. Georg Ringer merged patch set 3 12/07/11, 08:15