Review main Merged

57046[BUGFIX] Allow writing temp files in composer mode

Benni Mack CR +2 V +2 Normal +146 −28 updated 05/29/18, 23:19

Commit message

The new Environment API allows to set the project path
outside of the web root, also moving typo3temp/var/
to env:PROJECT_PATH + var/.

However, the main method GeneralUtility::writeFileToTypo3tempDir()
which is used for adding online media, charset conversion etc.
is not adapted to allow files outside of typo3temp/
which needs adaptions wo also check for PROJECT_PATH + var/
in addition.

Some generic tests were added to ensure the existing functionality
still works.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Andreas Kienast +1
    • Jigal van Hemert +1
    • Susi Moog +1
    • Petra Arentzen +1
  • Verified V +2
    • Christian Kuhn +2
    • Jigal van Hemert +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1012

  1. Benni Mack uploaded patch set 1 05/25/18, 07:45

  2. Wouter Wolters commented on patch set 2 05/25/18, 07:51

    Published edit on patch set 1.
  3. Wouter Wolters voted on patch set 2 CR +1 05/25/18, 07:51

  4. TYPO3com voted on patch set 1 V +1 05/25/18, 07:52 Completed build in 07m 17s on Fri, 25 May, 09:52 AM Test Summary: 31128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23758

  5. TYPO3com voted on patch set 2 V +1 05/25/18, 07:58 Completed build in 06m 32s on Fri, 25 May, 09:58 AM Test Summary: 31128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23759

  6. Susi Moog voted on patch set 2 CR +1 05/25/18, 08:01

  7. Andreas Kienast voted on patch set 2 CR +1 05/25/18, 08:17

  8. Tymoteusz Motylewski commented on patch set 2 05/29/18, 11:41

  9. Petra Arentzen commented on patch set 2 CR +1 05/29/18, 20:22

  10. Jigal van Hemert voted on patch set 2 V +1 CR +1 05/29/18, 20:35

  11. Christian Kuhn voted on patch set 2 V +2 CR +2 05/29/18, 23:17

  12. Christian Kuhn merged patch set 3 05/29/18, 23:19