57047[TASK] Deprecate PageRepository->versioningPreview
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Wouter Wolters +1
-
Verified V +2
- Christian Kuhn +2
- Wouter Wolters +1
- TYPO3com +1 CI
Issues 1
Files 13
- typo3/sysext/core/Classes/Database/Query/Restriction/FrontendWorkspaceRestriction.php+2 −2
- typo3/sysext/core/Classes/Utility/RootlineUtility.php+1 −8
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-85078-PageRepositoryVersioningPreview.rstnew+37 −0
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/FrontendRestrictionContainerTest.php+0 −12
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/FrontendWorkspaceRestrictionTest.php+4 −6
- typo3/sysext/core/Tests/Unit/Utility/RootlineUtilityTest.php+3 −6
- typo3/sysext/extbase/Tests/Functional/Persistence/RelationTest.php+1 −0
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Storage/Typo3DbBackendTest.php+0 −1
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+1 −1
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+0 −2
- typo3/sysext/frontend/Classes/Page/PageRepository.php1+41 −38
- typo3/sysext/frontend/Tests/Functional/Page/PageRepositoryTest.php+4 −25
- typo3/sysext/install/Configuration/ExtensionScanner/Php/PropertyPublicMatcher.php+5 −0
Review log 1927
Show 12 earlier messages
-
Benni Mack uploaded patch set 1 05/25/18, 08:40
-
TYPO3com voted on patch set 1 V -1 05/25/18, 08:47 Completed build in 06m 48s on Fri, 25 May, 10:47 AM Test Summary: 211 of 31342 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23762
-
Benni Mack uploaded patch set 2 05/25/18, 09:03
-
TYPO3com voted on patch set 2 V -1 05/25/18, 09:10 Completed build in 07m 24s on Fri, 25 May, 11:10 AM Test Summary: 208 of 31342 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23764
-
Benni Mack uploaded patch set 3 05/28/18, 21:55
-
TYPO3com voted on patch set 3 V -1 05/28/18, 22:02 Completed build in 07m 01s on Tue, 29 May, 12:02 AM Test Summary: 204 of 31367 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23852
-
Benni Mack uploaded patch set 4 05/29/18, 10:36
-
TYPO3com voted on patch set 4 V -1 05/29/18, 10:43 Completed build in 07m 01s on Tue, 29 May, 12:43 PM Test Summary: 204 of 31367 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23860
-
Benni Mack commented on patch set 5 05/29/18, 17:06
Published edit on patch set 4. -
TYPO3com voted on patch set 5 V -1 05/29/18, 17:13 Completed build in 07m 25s on Tue, 29 May, 07:13 PM Test Summary: 204 of 31367 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23871
-
Benni Mack uploaded patch set 6 05/29/18, 18:10
-
TYPO3com voted on patch set 6 V +1 05/29/18, 18:17 Completed build in 07m 00s on Tue, 29 May, 08:17 PM Test Summary: 31120 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23872
-
Benni Mack uploaded patch set 7 05/29/18, 18:25
-
TYPO3com voted on patch set 7 V +1 05/29/18, 18:32 Completed build in 07m 05s on Tue, 29 May, 08:32 PM Test Summary: 31120 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23873
-
Wouter Wolters voted on patch set 7 CR +1 05/30/18, 18:05
-
Wouter Wolters voted on patch set 7 V +1 05/30/18, 18:07
-
Benni Mack uploaded patch set 8 05/30/18, 20:02
-
Wouter Wolters voted on patch set 8 V +1 CR +1 05/30/18, 20:04
-
TYPO3com voted on patch set 8 V +1 05/30/18, 20:10 Completed build in 08m 02s on Wed, 30 May, 10:10 PM Test Summary: 31147 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23920
-
Christian Kuhn voted on patch set 8 V +2 CR +2 05/30/18, 20:38
-
Christian Kuhn merged patch set 9 05/30/18, 20:39
-
Markus Klein commented on patch set 9 10/04/18, 16:19
Post -1. versioningPreview has been replaced with workspaceId in all places. The definition was: versioningPreview = $this->whichWorkspace() > 0 in some if statements the condition if (versioningPreview ) is now if (workspaceid), which is wrong, because workmspaceId has a default value of -99! -
Benni Mack commented on patch set 9 10/04/18, 16:20
that _is_ still correct. "-99" means no access to live nor any other preview workspace. -
Frank Nägler commented on patch set 9 10/04/18, 16:25
-99 is the default in BackendUserAuthentication -
Frank Nägler commented on patch set 9 10/04/18, 16:26
and, I have EXT:workspaces not installed -
Markus Klein commented on patch set 9 10/04/18, 16:50
PageRepository.php:193this is one place which is wrong. versioningPreview was only true if "versioningWorkspaceId > 0" Now the condition is also true if workspaceid is -99 -
Markus Klein commented on patch set 9 10/04/18, 20:26
fix with https://forge.typo3.org/issues/86574