Review main Merged

57047[TASK] Deprecate PageRepository->versioningPreview

Benni Mack CR +2 V +2 Normal +99 −101 updated 10/04/18, 20:26

Commit message

PageRepository has two public properties regarding
fetching records for versioned records:
- versioningPreview (bool)
- versioningWorkspaceId (int)

In order to allow previews of versions, a workspace ID
has to be set - otherwise it fetches live records.

Basically things like: $versioningPreview=false,
$versioningWorkspaceId=3 will make things more confusing.

Instead, versioningPreview is not in use anymore,
and PageRepository solely relies on the parameter
of the workspaceId set.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 13

Review log 1927

Show 12 earlier messages
  1. Benni Mack uploaded patch set 1 05/25/18, 08:40

  2. TYPO3com voted on patch set 1 V -1 05/25/18, 08:47 Completed build in 06m 48s on Fri, 25 May, 10:47 AM Test Summary: 211 of 31342 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23762

  1. Benni Mack uploaded patch set 2 05/25/18, 09:03

  2. TYPO3com voted on patch set 2 V -1 05/25/18, 09:10 Completed build in 07m 24s on Fri, 25 May, 11:10 AM Test Summary: 208 of 31342 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23764

  3. Benni Mack uploaded patch set 3 05/28/18, 21:55

  4. TYPO3com voted on patch set 3 V -1 05/28/18, 22:02 Completed build in 07m 01s on Tue, 29 May, 12:02 AM Test Summary: 204 of 31367 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23852

  5. Benni Mack uploaded patch set 4 05/29/18, 10:36

  6. TYPO3com voted on patch set 4 V -1 05/29/18, 10:43 Completed build in 07m 01s on Tue, 29 May, 12:43 PM Test Summary: 204 of 31367 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23860

  7. Benni Mack commented on patch set 5 05/29/18, 17:06

    Published edit on patch set 4.
  8. TYPO3com voted on patch set 5 V -1 05/29/18, 17:13 Completed build in 07m 25s on Tue, 29 May, 07:13 PM Test Summary: 204 of 31367 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23871

  9. Benni Mack uploaded patch set 6 05/29/18, 18:10

  10. TYPO3com voted on patch set 6 V +1 05/29/18, 18:17 Completed build in 07m 00s on Tue, 29 May, 08:17 PM Test Summary: 31120 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23872

  11. Benni Mack uploaded patch set 7 05/29/18, 18:25

  12. TYPO3com voted on patch set 7 V +1 05/29/18, 18:32 Completed build in 07m 05s on Tue, 29 May, 08:32 PM Test Summary: 31120 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23873

  13. Wouter Wolters voted on patch set 7 CR +1 05/30/18, 18:05

  14. Wouter Wolters voted on patch set 7 V +1 05/30/18, 18:07

  15. Benni Mack uploaded patch set 8 05/30/18, 20:02

  16. Wouter Wolters voted on patch set 8 V +1 CR +1 05/30/18, 20:04

  17. TYPO3com voted on patch set 8 V +1 05/30/18, 20:10 Completed build in 08m 02s on Wed, 30 May, 10:10 PM Test Summary: 31147 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23920

  18. Christian Kuhn voted on patch set 8 V +2 CR +2 05/30/18, 20:38

  19. Christian Kuhn merged patch set 9 05/30/18, 20:39

  20. Markus Klein commented on patch set 9 10/04/18, 16:19

    Post -1. versioningPreview has been replaced with workspaceId in all places. The definition was: versioningPreview = $this->whichWorkspace() > 0 in some if statements the condition if (versioningPreview ) is now if (workspaceid), which is wrong, because workmspaceId has a default value of -99!
  21. Benni Mack commented on patch set 9 10/04/18, 16:20

    that _is_ still correct. "-99" means no access to live nor any other preview workspace.
  22. Frank Nägler commented on patch set 9 10/04/18, 16:25

    -99 is the default in BackendUserAuthentication
  23. Frank Nägler commented on patch set 9 10/04/18, 16:26

    and, I have EXT:workspaces not installed
  24. Markus Klein commented on patch set 9 10/04/18, 16:50

    PageRepository.php:193

    this is one place which is wrong. versioningPreview was only true if "versioningWorkspaceId > 0" Now the condition is also true if workspaceid is -99
  25. Markus Klein commented on patch set 9 10/04/18, 20:26