57057[BUGFIX] Clean up error handler for site handling
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Wouter Wolters +1
-
Verified V +2
- Georg Ringer +2
- Wouter Wolters +1
- TYPO3com +1 CI
Issues 1
Files 6
- typo3/sysext/core/Classes/Error/PageErrorHandler/FluidPageErrorHandler.phprenamed+1 −1
- typo3/sysext/core/Classes/Error/PageErrorHandler/InvalidPageErrorHandlerException.phpnew+27 −0
- typo3/sysext/core/Classes/Error/PageErrorHandler/PageContentErrorHandler.phprenamed+3 −4
- typo3/sysext/core/Classes/Error/PageErrorHandler/PageErrorHandlerInterface.phprenamed+5 −3
- typo3/sysext/core/Classes/Site/Entity/Site.php+14 −12
- typo3/sysext/core/Tests/Unit/Site/Entity/SiteTest.phpnew+116 −0
Review log 710
-
Benni Mack uploaded patch set 1 05/27/18, 15:12
-
TYPO3com voted on patch set 1 V -1 05/27/18, 15:12 Completed build in 06s on Sun, 27 May, 05:12 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23795
-
Benni Mack uploaded patch set 2 05/27/18, 15:17
-
TYPO3com voted on patch set 2 V -1 05/27/18, 15:17 Completed build in 06s on Sun, 27 May, 05:17 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23796
-
Benni Mack uploaded patch set 3 05/28/18, 17:35
-
TYPO3com voted on patch set 3 V +1 05/28/18, 17:42 Completed build in 06m 52s on Mon, 28 May, 07:42 PM Test Summary: 31122 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23837
-
Wouter Wolters voted on patch set 3 CR +1 05/28/18, 18:06
-
Wouter Wolters voted on patch set 3 V +1 05/28/18, 18:23
-
Georg Ringer voted on patch set 3 V +2 CR +2 05/28/18, 19:14
-
Georg Ringer merged patch set 4 05/28/18, 19:14