Review main Merged

57057[BUGFIX] Clean up error handler for site handling

Benni Mack CR +2 V +2 Normal +166 −20 updated 05/28/18, 19:14

Commit message

This patch handles several issues related to the new
site error handling introduced in TYPO3 v9.2.0:

1. It adds unit tests
2. It adds a missing exception when an error handler
is configured which does not implement the PageErrorHandlerInterface
3. It fixes one minor issue in PageContentErrorHandler
where a wrong "InvalidArgumentException" was thrown
4. All PageErrorHandler logic was moved from EXT:frontend
to EXT:core, as this would be a penalty across packages -
the "Site" entity depends on them, so they must go to the same
package (core).

Review

  • Code review CR +2
    • Georg Ringer +2
    • Wouter Wolters +1
  • Verified V +2
    • Georg Ringer +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 710

  1. Benni Mack uploaded patch set 1 05/27/18, 15:12

  2. TYPO3com voted on patch set 1 V -1 05/27/18, 15:12 Completed build in 06s on Sun, 27 May, 05:12 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23795

  3. Benni Mack uploaded patch set 2 05/27/18, 15:17

  4. TYPO3com voted on patch set 2 V -1 05/27/18, 15:17 Completed build in 06s on Sun, 27 May, 05:17 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23796

  5. Benni Mack uploaded patch set 3 05/28/18, 17:35

  6. TYPO3com voted on patch set 3 V +1 05/28/18, 17:42 Completed build in 06m 52s on Mon, 28 May, 07:42 PM Test Summary: 31122 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23837

  7. Wouter Wolters voted on patch set 3 CR +1 05/28/18, 18:06

  8. Wouter Wolters voted on patch set 3 V +1 05/28/18, 18:23

  9. Georg Ringer voted on patch set 3 V +2 CR +2 05/28/18, 19:14

  10. Georg Ringer merged patch set 4 05/28/18, 19:14