5706[BUGFIX] EM: Fix button "close window" after fulfilling dependencies
Commit message
Review
-
Code review CR +2
- Jigal van Hemert +2
- Xavier Perseguers +1
-
Verified V +2
- Jigal van Hemert +2
- Xavier Perseguers +1
Issues 1
Files 2
Review log 19
-
Xavier Perseguers commented on patch set 1 10/11/11, 13:28
Looks good to me, but someone else must approve Except the commit title, +1 by reading, will test it soon[BUGFIX] EM: Fix button "close window" after fulfilling dependencies -
Xavier Perseguers uploaded patch set 3 10/11/11, 13:28
-
Xavier Perseguers commented on patch set 3 10/11/11, 13:28
Looks good to me, but someone else must approve Fixed the commit message which was still not what I asked for :) -
Xavier Perseguers commented on patch set 3 10/11/11, 13:28
Fails Using FF5 having a dependency to be downloaded from TER opens a new empty tab and does nothing. Without this patch this opens a tab and download the corresponding extension -
Kay Strobach uploaded patch set 2 10/11/11, 13:28
-
Kay Strobach uploaded patch set 4 10/11/11, 13:28
-
Xavier Perseguers commented on patch set 5 10/11/11, 13:28
Verified; Looks good to me, but someone else must approve -
Kay Strobach uploaded patch set 5 10/11/11, 13:28
-
Xavier Perseguers commented on patch set 6 10/11/11, 13:28
Verified; Looks good to me, but someone else must approve -
Kay Strobach uploaded patch set 6 10/11/11, 13:28
-
Jigal van Hemert commented on patch set 6 V 0 10/11/11, 13:28
by team member; Looks good to me, approved Still a bit ugly popups, but enough for RC1; it improves functionality a lot! -
Jigal van Hemert merged patch set 6 10/11/11, 13:28
-
Mr. Jenkins commented on patch set 1 10/11/11, 13:28
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2109/ : SUCCESS -
Mr. Jenkins commented on patch set 2 10/11/11, 13:28
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2112/ : SUCCESS -
Mr. Jenkins commented on patch set 3 10/11/11, 13:28
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2117/ : SUCCESS -
Mr. Jenkins commented on patch set 4 10/11/11, 13:28
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2121/ : SUCCESS -
Mr. Jenkins commented on patch set 5 10/11/11, 13:28
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2122/ : SUCCESS -
Mr. Jenkins commented on patch set 6 10/11/11, 13:28
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2124/ : SUCCESS -
Kay Strobach commented on patch set 6 10/11/11, 13:28
jepp there should be an extjs only version lateron ;), but here is the principle "form follows function" ;)