Review main Merged

5706[BUGFIX] EM: Fix button "close window" after fulfilling dependencies

Kay Strobach CR +2 V +2 Easy +9 −9 updated 06/03/13, 20:49

Commit message

This fix opens the window in a sized window and changes the logic to
determine the correct function for closing the window.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Xavier Perseguers +1
  • Verified V +2
    • Jigal van Hemert +2
    • Xavier Perseguers +1

Issues 1

Files 2

Review log 19

  1. Xavier Perseguers commented on patch set 1 10/11/11, 13:28

    Looks good to me, but someone else must approve Except the commit title, +1 by reading, will test it soon
    [BUGFIX] EM: Fix button "close window" after fulfilling dependencies
  2. Xavier Perseguers uploaded patch set 3 10/11/11, 13:28

  3. Xavier Perseguers commented on patch set 3 10/11/11, 13:28

    Looks good to me, but someone else must approve Fixed the commit message which was still not what I asked for :)
  4. Xavier Perseguers commented on patch set 3 10/11/11, 13:28

    Fails Using FF5 having a dependency to be downloaded from TER opens a new empty tab and does nothing. Without this patch this opens a tab and download the corresponding extension
  5. Kay Strobach uploaded patch set 2 10/11/11, 13:28

  6. Kay Strobach uploaded patch set 4 10/11/11, 13:28

  7. Xavier Perseguers commented on patch set 5 10/11/11, 13:28

    Verified; Looks good to me, but someone else must approve
  8. Kay Strobach uploaded patch set 5 10/11/11, 13:28

  9. Xavier Perseguers commented on patch set 6 10/11/11, 13:28

    Verified; Looks good to me, but someone else must approve
  10. Kay Strobach uploaded patch set 6 10/11/11, 13:28

  11. Jigal van Hemert commented on patch set 6 V 0 10/11/11, 13:28

    by team member; Looks good to me, approved Still a bit ugly popups, but enough for RC1; it improves functionality a lot!
  12. Jigal van Hemert merged patch set 6 10/11/11, 13:28

  13. Mr. Jenkins commented on patch set 1 10/11/11, 13:28

  14. Mr. Jenkins commented on patch set 2 10/11/11, 13:28

  15. Mr. Jenkins commented on patch set 3 10/11/11, 13:28

  16. Mr. Jenkins commented on patch set 4 10/11/11, 13:28

  17. Mr. Jenkins commented on patch set 5 10/11/11, 13:28

  18. Mr. Jenkins commented on patch set 6 10/11/11, 13:28

  19. Kay Strobach commented on patch set 6 10/11/11, 13:28

    jepp there should be an extjs only version lateron ;), but here is the principle "form follows function" ;)