Review main Merged

57071[TASK] Deprecate PhpOptionsUtility

Benni Mack CR +2 V +2 Normal +79 −1 updated 05/29/18, 06:08

Commit message

The utility class was thinned out in the last TYPO3
versions and now is only used in EXT:install.

The functionality can be moved into EXT:install,
and PhpOptionsUtility can be deprecated, marked
as deprecated and awaiting removal in TYPO3 v10.0.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Wouter Wolters +1
    • Jörg Bösche +1
  • Verified V +2
    • Andreas Kienast +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 68

  1. Benni Mack uploaded patch set 1 05/28/18, 18:29

  2. Wouter Wolters voted on patch set 1 CR +1 05/28/18, 18:31

  3. TYPO3com voted on patch set 1 V -1 05/28/18, 18:37 Completed build in 08m 12s on Mon, 28 May, 08:37 PM Test Summary: 1 of 31358 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23838

  4. TYPO3com voted on patch set 1 V +1 05/28/18, 19:23 Completed build in 1h 01m 59s on Mon, 28 May, 09:23 PM Test Summary: 31110 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23838

  5. Wouter Wolters voted on patch set 1 V +1 05/28/18, 19:43

  6. Jörg Bösche voted on patch set 1 CR +1 05/29/18, 05:59

  7. Andreas Kienast voted on patch set 1 V +2 CR +2 05/29/18, 06:08

  8. Andreas Kienast merged patch set 2 05/29/18, 06:08