Review main Abandoned

57072[WIP][TASK] Drop special handling for "t3ver_label" database field

Benni Mack CR 0 V 0 Normal +6 −112 updated 06/09/18, 18:07

Commit message

The special field "t3ver_label" which was used in TYPO3 v4.x to store arbitrary comments
on a record, but was only used in workspaces to override and write fields, has been removed
from TCA. The DataHandler and workspaces does not fill the database field anymore.

However, due to backwards-compatibility the fields in SQL (TCA hook to create fields) are
still kept in order to avoid a breaking change - that can happen in TYPO3 v10.0.

Review

  • Code review CR 0
  • Verified V 0

Files 19

Review log 36

  1. Benni Mack uploaded patch set 1 05/28/18, 19:13

  2. TYPO3com voted on patch set 1 V -1 05/28/18, 19:23 Completed build in 09m 44s on Mon, 28 May, 09:23 PM Test Summary: 1 of 31357 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23839

  3. TYPO3com commented on patch set 1 05/28/18, 21:53 Completed build in 2h 49m 36s on Mon, 28 May, 11:53 PM Test Summary: 1 of 31357 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23839

  4. Benni Mack uploaded patch set 2 06/08/18, 06:24

  5. TYPO3com voted on patch set 2 V +1 06/08/18, 06:31 Completed build in 07m 21s on Fri, 8 Jun, 08:31 AM Test Summary: 31235 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24156

  6. Benni Mack abandoned the change 06/09/18, 18:07