Review main Merged

57074[TASK] Remove extra check for pageNotFoundHandling

Benni Mack CR +2 V +2 Easy +13 −21 updated 06/09/18, 15:59

Commit message

This fixes a functional test in EXT:workspaces,
allowing for getting rid of an extra check in the
frontend request workflow.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Oliver Hader +1
  • Verified V +2
    • Christian Kuhn +2
    • Oliver Hader +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 813

  1. Benni Mack uploaded patch set 1 05/28/18, 19:54

  2. TYPO3com voted on patch set 1 V -1 05/28/18, 20:01 Completed build in 06m 58s on Mon, 28 May, 10:01 PM Test Summary: 11 of 31369 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23847

  3. Oliver Hader uploaded patch set 2 05/28/18, 22:12

  4. TYPO3com voted on patch set 2 V -1 05/28/18, 22:19 Completed build in 06m 52s on Tue, 29 May, 12:19 AM Test Summary: 11 of 31369 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23853

  5. Benni Mack updated the commit message in patch set 3 06/07/18, 14:43

  6. TYPO3com voted on patch set 3 V -1 06/07/18, 14:52 Completed build in 08m 49s on Thu, 7 Jun, 04:52 PM Test Summary: 13 of 31482 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24120

  7. Benni Mack rebased onto patch set 4 06/09/18, 15:11

  8. TYPO3com voted on patch set 4 V +1 06/09/18, 15:22 Completed build in 10m 03s on Sat, 9 Jun, 05:22 PM Test Summary: 32692 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24213

  9. Benni Mack updated the commit message in patch set 5 06/09/18, 15:23

  10. TYPO3com voted on patch set 5 V +1 06/09/18, 15:31 Completed build in 08m 37s on Sat, 9 Jun, 05:31 PM Test Summary: 32692 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24216

  11. Oliver Hader voted on patch set 5 V +1 CR +1 06/09/18, 15:44

  12. Christian Kuhn voted on patch set 5 V +2 CR +2 06/09/18, 15:59

  13. Christian Kuhn merged patch set 6 06/09/18, 15:59