57075[TASK] Deprecate 3rd argument in PageRepository->getRootLine()
Commit message
Review
-
Code review CR +2
- Tymoteusz Motylewski +2
- Wouter Wolters +1
- Christian Kuhn +1
- Mathias Brodala +1
-
Verified V +2
- Tymoteusz Motylewski +2
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 5
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-85105-3rdMethodArgumentInPageRepository-getRootLine.rstnew+37 −0
- typo3/sysext/extbase/Classes/Configuration/BackendConfigurationManager.php+6 −5
- typo3/sysext/frontend/Classes/Page/PageRepository.php+6 −1
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php+5 −1
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodArgumentDroppedMatcher.php+6 −0
Review log 811
-
Benni Mack uploaded patch set 1 05/28/18, 20:10
-
TYPO3com voted on patch set 1 V +1 05/28/18, 20:18 Completed build in 08m 00s on Mon, 28 May, 10:18 PM Test Summary: 31122 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23848
-
Wouter Wolters voted on patch set 1 CR +1 05/28/18, 20:19
-
Mathias Brodala commented on patch set 2 05/29/18, 07:19
Published edit on patch set 1. -
Mathias Brodala voted on patch set 2 CR +1 05/29/18, 07:19
-
TYPO3com voted on patch set 2 V -1 05/29/18, 07:27 Completed build in 08m 26s on Tue, 29 May, 09:27 AM Test Summary: 1 of 31370 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23858
-
TYPO3com voted on patch set 2 V +1 05/29/18, 07:32 Completed build in 21m 16s on Tue, 29 May, 09:32 AM Test Summary: 31122 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23858
-
Wouter Wolters voted on patch set 2 CR +1 05/29/18, 20:56
-
Christian Kuhn voted on patch set 2 V +1 CR +1 05/29/18, 21:32
-
Tymoteusz Motylewski voted on patch set 2 V +2 CR +2 05/29/18, 21:38
-
Tymoteusz Motylewski merged patch set 3 05/29/18, 21:38