Review main Merged

57076[BUGFIX] Remember selected page in fsMod and refactor page selection

Tymoteusz Motylewski CR +2 V +2 Normal +59 −34 updated 08/08/18, 20:33

Commit message

Currently selected page is remembered in the fsMod js object.
The JS code responsible for handling click on the node text and node
background is refactored. Now both uses node.checked property.

Review

  • Code review CR +2
    • Benni Mack +2
    • Wouter Wolters +1
    • Andreas Kienast +1
  • Verified V +2
    • Benni Mack +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 2

Files 6

Review log 810

  1. Tymoteusz Motylewski uploaded patch set 1 05/28/18, 20:29

  2. TYPO3com voted on patch set 1 V +1 05/28/18, 20:38 Completed build in 08m 31s on Mon, 28 May, 10:38 PM Test Summary: 31122 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23849

  3. Tymoteusz Motylewski updated the commit message in patch set 2 05/29/18, 13:22

  4. TYPO3com voted on patch set 2 V +1 05/29/18, 13:29 Completed build in 06m 58s on Tue, 29 May, 03:29 PM Test Summary: 31122 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23862

  5. Wouter Wolters voted on patch set 2 CR +1 05/29/18, 19:16

  6. Benni Mack voted on patch set 2 V +1 05/30/18, 17:08

  7. Andreas Kienast voted on patch set 2 V +1 CR +1 05/30/18, 19:33

  8. Benni Mack voted on patch set 2 V +2 CR +2 05/30/18, 20:22

  9. Benni Mack merged patch set 3 05/30/18, 20:22

  10. Andreas Kienast commented on patch set 3 08/08/18, 20:33

    Post -1: Having

    PageTree.js:313 Unresolved

    Post -1: This call is responsible for rendering the "Do you want to close without saving?" modal when having unsaved changes in FormEngine twice.