Review main Merged

57082[BUGFIX] Always prefer HTTPS for cross-domain links

Mathias Brodala CR +2 V +2 Easy +1 −3 updated 05/30/18, 07:47

Commit message

This expands the logic for forced absolute URLs to all cases and
ensures HTTPS is kept for cross-domain links if possible.

Review

  • Code review CR +2
    • Mathias Brodala +2
    • Tobi Kretschmann +1
    • Wouter Wolters +1
    • Tymoteusz Motylewski +1
    • Andreas Kienast +1
    • Jörg Bösche +1
    • Jigal van Hemert +1
  • Verified V +2
    • Mathias Brodala +2
    • Tobi Kretschmann +1
    • Jörg Bösche +1
    • Jigal van Hemert +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1011

  1. Mathias Brodala uploaded patch set 1 05/29/18, 14:18

  2. TYPO3com voted on patch set 1 V +1 05/29/18, 14:27 Completed build in 08m 37s on Tue, 29 May, 04:27 PM Test Summary: 31122 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23864

  3. Tymoteusz Motylewski voted on patch set 1 CR +1 05/29/18, 16:08

  4. Jigal van Hemert voted on patch set 1 V +1 CR +1 05/29/18, 18:06

  5. Wouter Wolters voted on patch set 1 CR +1 05/29/18, 19:14

  6. Jörg Bösche voted on patch set 1 V +1 CR +1 05/30/18, 06:09

  7. Tobi Kretschmann voted on patch set 1 V +1 CR +1 05/30/18, 06:12

  8. Andreas Kienast voted on patch set 1 CR +1 05/30/18, 07:40

  9. Mathias Brodala voted on patch set 1 V +2 CR +2 05/30/18, 07:47

  10. Mathias Brodala merged patch set 2 05/30/18, 07:47

  11. Mathias Brodala commented on patch set 2 05/30/18, 07:47

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit b80424e4f32b4414f561c58cd1363885fce2ba91