Review main Merged

57088[TASK] Change visibility of CharsetConverter init methods

Benni Mack CR +2 V +2 Easy +28 −8 updated 05/30/18, 12:27

Commit message

Various CharsetConverter methods are there for initialization conversion,
which are marked as @private and are only used within the class.

The patch switches the method signatures from public to protected.

The following methods are affected:
- initCharset()
- initUnicodeData()
- initCaseFolding()
- initToASCII()

Review

  • Code review CR +2
    • Jan Helke +2
    • Georg Ringer +1
    • Wouter Wolters +1
    • Mathias Brodala +1
  • Verified V +2
    • Jan Helke +2
    • Georg Ringer +1
    • Mathias Brodala +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 810

  1. Benni Mack uploaded patch set 1 05/30/18, 09:44

  2. Mathias Brodala commented on patch set 2 05/30/18, 09:50

    Published edit on patch set 1.
  3. Mathias Brodala voted on patch set 2 CR +1 05/30/18, 09:50

  4. TYPO3com voted on patch set 1 V +1 05/30/18, 09:53 Completed build in 08m 50s on Wed, 30 May, 11:53 AM Test Summary: 31167 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23898

  5. TYPO3com voted on patch set 2 V +1 05/30/18, 09:59 Completed build in 08m 44s on Wed, 30 May, 11:59 AM Test Summary: 31167 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23899

  6. Georg Ringer voted on patch set 2 V +1 CR +1 05/30/18, 11:20

  7. Wouter Wolters voted on patch set 2 CR +1 05/30/18, 11:34

  8. Mathias Brodala commented on patch set 2 V +1 05/30/18, 11:49

    Verified by Bamboo, 3rd party should not call these methods anyways.
  9. Jan Helke voted on patch set 2 V +2 CR +2 05/30/18, 12:27

  10. Jan Helke merged patch set 3 05/30/18, 12:27