Review TYPO3_8-7 Merged

57092[BUGFIX] PHP 7 Reflection error for default value

Mathias Brodala CR +2 V +2 Easy +1 −2 updated 06/01/18, 15:00

Commit message

In PHP 7, under some circumstances the exception is not caught
as expected.
Therefore we use a check (as already done in ReflectionService.php).

Review

  • Code review CR +2
    • Jan Helke +2
    • Anja Leichsenring +1
    • Mona Muzaffar +1
  • Verified V +2
    • Jan Helke +2
    • Anja Leichsenring +1
    • Mona Muzaffar +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Mathias Brodala commented on patch set 1 05/30/18, 14:57

    Cherry Picked from branch TYPO3_7-6.
  2. TYPO3com voted on patch set 1 V +1 05/30/18, 15:11 Completed build in 13m 58s on Wed, 30 May, 05:11 PM Test Summary: 58350 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2521

  3. Anja Leichsenring voted on patch set 1 V +1 CR +1 06/01/18, 12:51

  4. Mona Muzaffar voted on patch set 1 V +1 CR +1 06/01/18, 12:58

  5. Jan Helke voted on patch set 1 V +2 CR +2 06/01/18, 14:56

  6. Jan Helke merged patch set 2 06/01/18, 15:00