Review main Merged

57093[TASK] Deprecate JavaScriptEncoder class

Benni Mack CR +2 V +2 Easy +44 −1 updated 05/30/18, 17:49

Commit message

The JavaScriptEncoder class was superseded with GeneralUtility::quoteJSvalue() in TYPO3 6.2
and is not used anymore. It is marked as deprecated.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 56

  1. Benni Mack uploaded patch set 1 05/30/18, 17:26

  2. Wouter Wolters voted on patch set 1 CR +1 05/30/18, 17:29

  3. TYPO3com voted on patch set 1 V +1 05/30/18, 17:33 Completed build in 06m 56s on Wed, 30 May, 07:33 PM Test Summary: 31149 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23906

  4. Wouter Wolters voted on patch set 1 V +1 05/30/18, 17:34

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 05/30/18, 17:48

  6. Christian Kuhn merged patch set 2 05/30/18, 17:49